diff --git a/change/@fluentui-react-charting-f4a76a60-ac00-42f5-890d-6acd079452b8.json b/change/@fluentui-react-charting-f4a76a60-ac00-42f5-890d-6acd079452b8.json new file mode 100644 index 00000000000000..4458f80b6164e7 --- /dev/null +++ b/change/@fluentui-react-charting-f4a76a60-ac00-42f5-890d-6acd079452b8.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fixing line not visible bug for vertical bar chart", + "packageName": "@fluentui/react-charting", + "email": "srmukher@microsoft.com", + "dependentChangeType": "patch" +} diff --git a/packages/react-charting/src/utilities/utilities.ts b/packages/react-charting/src/utilities/utilities.ts index 7d924c721310fc..476fb763761b0d 100644 --- a/packages/react-charting/src/utilities/utilities.ts +++ b/packages/react-charting/src/utilities/utilities.ts @@ -1128,8 +1128,28 @@ export function findVerticalNumericMinMaxOfY(points: IVerticalBarChartDataPoint[ startValue: number; endValue: number; } { - const yMax = d3Max(points, (point: IVerticalBarChartDataPoint) => point.y)!; - const yMin = d3Min(points, (point: IVerticalBarChartDataPoint) => point.y)!; + const yMax = d3Max(points, (point: IVerticalBarChartDataPoint) => { + if (point.lineData !== undefined) { + if (point.y > point.lineData!.y) { + return point.y; + } else { + return point.lineData!.y; + } + } else { + return point.y; + } + })!; + const yMin = d3Min(points, (point: IVerticalBarChartDataPoint) => { + if (point.lineData !== undefined) { + if (point.y < point.lineData!.y) { + return point.y; + } else { + return point.lineData!.y; + } + } else { + return point.y; + } + })!; return { startValue: yMin, endValue: yMax }; }