From dedf1f0f568611b574411c269f8efb88f5c4f5e9 Mon Sep 17 00:00:00 2001 From: Amr Eladawy Date: Sat, 16 Sep 2023 23:52:26 +0100 Subject: [PATCH 1/5] Update Pagination.base.tsx Add tool tip to all icon buttons --- .../components/Pagination/Pagination.base.tsx | 75 +++++++++++-------- 1 file changed, 45 insertions(+), 30 deletions(-) diff --git a/packages/react-experiments/src/components/Pagination/Pagination.base.tsx b/packages/react-experiments/src/components/Pagination/Pagination.base.tsx index b3594da7e63d9d..d013c5837604c1 100644 --- a/packages/react-experiments/src/components/Pagination/Pagination.base.tsx +++ b/packages/react-experiments/src/components/Pagination/Pagination.base.tsx @@ -118,37 +118,52 @@ export class PaginationBase extends React.Component { return (
- - + + + + + + {this._pageList()} - + + + Date: Fri, 29 Sep 2023 23:01:44 +0100 Subject: [PATCH 2/5] add yarn change --- ...t-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json diff --git a/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json b/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json new file mode 100644 index 00000000000000..57e102ed0804b3 --- /dev/null +++ b/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix a11y issue and add tooltip to pagination buttons.", + "packageName": "@fluentui/react-experiments", + "email": "amreladawy@mirosoft.com", + "dependentChangeType": "patch" +} From bad724dcf03f338e8a8e8878316f8a5356520c38 Mon Sep 17 00:00:00 2001 From: Ben Howell <48106640+behowell@users.noreply.github.com> Date: Fri, 29 Sep 2023 15:24:12 -0700 Subject: [PATCH 3/5] Update @fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json Fix format of change description --- ...-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json b/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json index 57e102ed0804b3..45bfd179c971ac 100644 --- a/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json +++ b/change/@fluentui-react-experiments-0f3a8927-b266-4199-ba8b-f59939a6f3a7.json @@ -1,6 +1,6 @@ { "type": "patch", - "comment": "Fix a11y issue and add tooltip to pagination buttons.", + "comment": "fix(Pagination) Add tooltips to pagination buttons.", "packageName": "@fluentui/react-experiments", "email": "amreladawy@mirosoft.com", "dependentChangeType": "patch" From 7c0261cc96e789ffd063b16c21493aa8447bac6d Mon Sep 17 00:00:00 2001 From: Amr Eladawy Date: Sat, 30 Sep 2023 13:51:17 +0100 Subject: [PATCH 4/5] formatter --- .../components/Pagination/Pagination.base.tsx | 21 ++++++------------- 1 file changed, 6 insertions(+), 15 deletions(-) diff --git a/packages/react-experiments/src/components/Pagination/Pagination.base.tsx b/packages/react-experiments/src/components/Pagination/Pagination.base.tsx index d013c5837604c1..abac90deb90f95 100644 --- a/packages/react-experiments/src/components/Pagination/Pagination.base.tsx +++ b/packages/react-experiments/src/components/Pagination/Pagination.base.tsx @@ -118,10 +118,7 @@ export class PaginationBase extends React.Component { return (
- + { rootDisabled: this._classNames.previousNextPageDisabled, }} /> - - + + { rootDisabled: this._classNames.previousNextPageDisabled, }} /> - + {this._pageList()} - + { rootDisabled: this._classNames.previousNextPageDisabled, }} /> - + Date: Mon, 2 Oct 2023 23:35:07 +0100 Subject: [PATCH 5/5] Snapshot updated --- .../__snapshots__/Pagination.test.tsx.snap | 780 ++++++++++-------- 1 file changed, 438 insertions(+), 342 deletions(-) diff --git a/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap b/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap index 6c58ca4fc61d20..d826e2e933e6d3 100644 --- a/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap +++ b/packages/react-experiments/src/components/Pagination/__snapshots__/Pagination.test.tsx.snap @@ -14,264 +14,328 @@ exports[`Pagination render buttons Pagination correctly 1`] = `
- + +
+
span { - left: 0px; - position: relative; - top: 0px; - } - &:hover { - outline: 0px; - } - &:focus { - outline: 0px; + display: inline; } - data-is-focusable={false} - disabled={true} - onClick={[Function]} + onBlurCapture={[Function]} + onFocusCapture={[Function]} onKeyDown={[Function]} - onKeyPress={[Function]} - onKeyUp={[Function]} - onMouseDown={[Function]} - onMouseUp={[Function]} - type="button" + onMouseEnter={[Function]} + onMouseLeave={[Function]} + role="none" > - span { + left: 0px; + position: relative; + top: 0px; + } + &:hover { + outline: 0px; + } + &:focus { + outline: 0px; + } + data-is-focusable={false} + disabled={true} + onClick={[Function]} + onKeyDown={[Function]} + onKeyPress={[Function]} + onKeyUp={[Function]} + onMouseDown={[Function]} + onMouseUp={[Function]} + type="button" > - + +  + + + + +
- + +