Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement build infra around TS path aliases for convergence #16889

Closed
13 tasks done
Hotell opened this issue Feb 9, 2021 · 6 comments
Closed
13 tasks done

Implement build infra around TS path aliases for convergence #16889

Hotell opened this issue Feb 9, 2021 · 6 comments

Comments

@Hotell
Copy link
Contributor

Hotell commented Feb 9, 2021

Epic

This is an Epic which will track implementation of issues pointed out in following documents:

Problem

  • need to build before run/test/demo
  • unified/explicit TSConfigs
  • missing co-located demos via storybook

Solution

  • we'll use TSConfig path aliases as the only source of truth for converged components.

Implementation:

Pre-requirements

Requirements:

Risks (Rabbit holes)

  • No idea about plop AST capabilities (might get into issues when I'll need to add new package to monorepoRoot/jest.config.js)
  • plop is not very testable AFAIR (will need to try it out)

Out of scope (No-gos)

  • using solution TS config style (project references per package) to explicitly distinguish between environments (story/implementation/test)
  • revamping all npm:scripts and how we build/publish
  • use babel for transpilation
  • use babel-jest for testing
  • use rollup as main bundler
@JustSlone
Copy link
Collaborator

Update:

  • 3 Pull requests out (see checklist above)
  • Discovered more issues, global types are leaking, not blocking currently - TODO: Create new RFC to tackle these

@Hotell
Copy link
Contributor Author

Hotell commented Feb 23, 2021

Update:

@Hotell
Copy link
Contributor Author

Hotell commented Mar 2, 2021

March goal: finish all tasks - every conformant package has the new DX implemented

@Hotell Hotell mentioned this issue Mar 8, 2021
1 task
@Hotell
Copy link
Contributor Author

Hotell commented Mar 9, 2021

@Hotell
Copy link
Contributor Author

Hotell commented Mar 16, 2021

  • added new task -> api-extractor integration with TS path aliases approach

Legend:

  • 🛠️ = in progress
  • 👁 = ready for review
  • 🛑 = blocked
  • ✅ = done

Status:

  • 🛠️ / api-extractor integration with TS path aliases approach
  • 🛠️ / local storybooks with global config

@Hotell
Copy link
Contributor Author

Hotell commented Mar 30, 2021

Status:
no updates - FHL week

@Hotell Hotell added this to the May Project Cycle Q2 2021 milestone May 11, 2021
@Hotell Hotell closed this as completed Jul 21, 2021
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants