From 6e5b24162fc79f619c427de72874a23b03a28728 Mon Sep 17 00:00:00 2001 From: Owen Campbell Date: Fri, 3 Oct 2025 15:11:05 -0700 Subject: [PATCH 1/3] Give wrapper element a different id from the canvas --- .../src/paint/fallback/fallbackPaintAnimation.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts b/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts index 38cd53be..68284d4b 100644 --- a/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts +++ b/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts @@ -47,11 +47,13 @@ export const fallbackPaintAnimation = ( running: false, }; + // Non-Houdini fallbacks require a canvas element be present in the DOM. // Create a wrapper for us to store these elements in so we avoid // thrashing the DOM with appends. if (!state.wrapper) { - state.wrapper = appendWrapper(state.id, targetDocument.body); + const wrapperId = `houdini-fallback-wrapper-${flairFallbackId}`; + state.wrapper = appendWrapper(wrapperId, targetDocument.body); } if (hasMozElement(targetWindow)) { From b8cb352c2011850fe9bc1120c6a95f88912e6e11 Mon Sep 17 00:00:00 2001 From: Owen Campbell Date: Fri, 3 Oct 2025 15:12:37 -0700 Subject: [PATCH 2/3] Change files --- ...houdini-utils-86e06910-e1e9-4dbc-ba21-b984551a5a04.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 change/@fluentui-contrib-houdini-utils-86e06910-e1e9-4dbc-ba21-b984551a5a04.json diff --git a/change/@fluentui-contrib-houdini-utils-86e06910-e1e9-4dbc-ba21-b984551a5a04.json b/change/@fluentui-contrib-houdini-utils-86e06910-e1e9-4dbc-ba21-b984551a5a04.json new file mode 100644 index 00000000..59a5ec54 --- /dev/null +++ b/change/@fluentui-contrib-houdini-utils-86e06910-e1e9-4dbc-ba21-b984551a5a04.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "fix: Give fallback wrapper a different id.", + "packageName": "@fluentui-contrib/houdini-utils", + "email": "owcampbe@microsoft.com", + "dependentChangeType": "patch" +} From cfb551bb19a4620bb31354b5582c4775020c651c Mon Sep 17 00:00:00 2001 From: Owen Campbell Date: Fri, 3 Oct 2025 15:15:10 -0700 Subject: [PATCH 3/3] Fix whitespace --- .../houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts b/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts index 68284d4b..6629305d 100644 --- a/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts +++ b/packages/houdini-utils/src/paint/fallback/fallbackPaintAnimation.ts @@ -47,7 +47,6 @@ export const fallbackPaintAnimation = ( running: false, }; - // Non-Houdini fallbacks require a canvas element be present in the DOM. // Create a wrapper for us to store these elements in so we avoid // thrashing the DOM with appends.