Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose PopoverVisible property on FluentProfileMenu #2737

Closed
brused27 opened this issue Sep 30, 2024 · 2 comments
Closed

feat: expose PopoverVisible property on FluentProfileMenu #2737

brused27 opened this issue Sep 30, 2024 · 2 comments
Assignees
Labels
status:needs-investigation Needs additional investigation triage New issue. Needs to be looked at
Milestone

Comments

@brused27
Copy link

🙋 Feature Request

I would like to be able to set the property PopoverVisible = true/false manually on the FluentProfileMenu component.

🤔 Expected Behavior

PopoverVisible is moved from a private property to a public property and has the [Parameter] attribute added.

😯 Current Behavior

I need to use reflection or custom JavaScript to help close this menu overlay as PopoverVisible is a private property on this component.

💁 Possible Solution

PopoverVisible is moved from a private property to a public property and has the [Parameter] attribute added.

🔦 Context

I am using a custom header/footer template and I am currently unable to easily close this menu should the app decide to trigger an action/navigation based upon a click that occurs inside this menu. There is currently no exposed visibility parameter on this component today.

We would not need to set this property via reflection and/or use JavaScript to help close the menu manually if this was updated.

💻 Examples

See Context above, I think this should be clear but let me know if not.

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Sep 30, 2024
@vnbaaij vnbaaij added the status:needs-investigation Needs additional investigation label Sep 30, 2024
@vnbaaij vnbaaij added this to the V4.10.2 milestone Sep 30, 2024
@dvoituron
Copy link
Collaborator

This could be interesting. I renamed this internal variable and exposed it externally using the name Open.

#2741

@brused27
Copy link
Author

brused27 commented Oct 1, 2024

Wow, thank you the quick response! This looks great and I'm looking forward to having it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:needs-investigation Needs additional investigation triage New issue. Needs to be looked at
Projects
None yet
Development

No branches or pull requests

3 participants