Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bpf_map_lookup_batch] Fix bpf_map_lookup_batch data retrieval and add test cases for percpu hash map batch lookup #3590

Merged
merged 14 commits into from
Jul 16, 2024
Merged

[bpf_map_lookup_batch] Fix bpf_map_lookup_batch data retrieval and add test cases for percpu hash map batch lookup #3590

merged 14 commits into from
Jul 16, 2024

Conversation

shpalani
Copy link
Collaborator

@shpalani shpalani commented May 28, 2024 •
edited
Loading

Description

Problem:

  1. bpf_map_lookup_batch failed to retrieve data for per-cpu map types.
  2. There were no test cases for per-cpu hash map types.

Resolution:

  1. Fixed the ebpf_map_lookup_element_batch function to get the right value_size for the per-cpu map types.
  2. Added test cases for the per-cpu hash.
  • BPF_MAP_TYPE_PERCPU_HASH
  • BPF_MAP_TYPE_LRU_PERCPU_HASH

Testing

_Do any existing tests cover this change? Yes.
Are new tests needed? Yes

Documentation

_Is there any documentation impact for this change? No

Installation

_Is there any installer impact for this change? No

@shpalani shpalani changed the title Initial commit [bpf_map_lookup_batch] Add test case for percpu hash map batch lookup May 28, 2024
@shpalani shpalani linked an issue May 29, 2024 that may be closed by this pull request
[bpf_map_lookup_batch map api]: Failed to retrieve data for per-cpu map types. No test cases for PERCPU hash map types. #3564
Closed
@shpalani shpalani marked this pull request as ready for review July 3, 2024 20:56
@shpalani shpalani changed the title [bpf_map_lookup_batch] Add test case for percpu hash map batch lookup [bpf_map_lookup_batch] Fix bpf_map_lookup_batch data retrieval and add test cases for percpu hash map batch lookup Jul 3, 2024
matthewige
matthewige reviewed Jul 10, 2024
View reviewed changes
tests/unit/libbpf_test.cpp Outdated Show resolved Hide resolved
libs/api/ebpf_api.cpp Show resolved Hide resolved
tests/unit/libbpf_test.cpp Show resolved Hide resolved
@shpalani shpalani added this pull request to the merge queue Jul 16, 2024
Merged via the queue into microsoft:main with commit 7ee9edf Jul 16, 2024
88 checks passed
@shpalani shpalani deleted the shpalan/map-percpu-hash branch July 16, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saxena-anurag saxena-anurag saxena-anurag left review comments

@shankarseal shankarseal shankarseal left review comments

@matthewige matthewige matthewige approved these changes

@Alan-Jowett Alan-Jowett Alan-Jowett approved these changes

@dthaler dthaler Awaiting requested review from dthaler dthaler is a code owner

@poornagmsft poornagmsft Awaiting requested review from poornagmsft poornagmsft is a code owner

@dv-msft dv-msft Awaiting requested review from dv-msft dv-msft is a code owner

@gtrevi gtrevi Awaiting requested review from gtrevi gtrevi is a code owner

@mtfriesen mtfriesen Awaiting requested review from mtfriesen mtfriesen is a code owner

@rectified95 rectified95 Awaiting requested review from rectified95 rectified95 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@shpalani @matthewige @Alan-Jowett @saxena-anurag @shankarseal