-
Notifications
You must be signed in to change notification settings - Fork 86
Add new packages to allowed names in npm banned types #350
base: master
Are you sure you want to change the base?
Add new packages to allowed names in npm banned types #350
Conversation
The assertion is not a rule, so it cannot be bypassed in DT config. - 'download-git-repo' - 'download-package-tarball' Both are published to NPM registry already. Required for: DefinitelyTyped/DefinitelyTyped#56874 DefinitelyTyped/DefinitelyTyped#56875 Thanks! /cc @LinqLover
7e65c8e
to
27f3a1c
Compare
The problem is that the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work because npm won't let us publish new packages with the word 'download' in it.
Should there be any policy for DefinitelyTyped to escape such names? E.g., for |
oh, so that does not matter JS source is already on NPM, @types/{banned-word} cannot be published. Thanks for clarification @LinqLover one can always submit just the same types directly to the original source code, so types are part of published package. |
But this comes with all the disadvantages of not going through DefinitelyTyped. Missing or slow maintenance ... |
oh, so, you think, DT is the opposite of those +1 |
closing after @sandersn comments, thx! |
See also microsoft#349 and microsoft#350. As soon as an official decision for this issue exists, that should be referenced in the docs as well.
IMO this draws the entire idea of TypeScript ad absurdum. Could please someone escalate this issue to
It's pretty irritating for new contributors like me to submit several PRs for packages after following the instructions in the DT repo precisely and then failing at this organizational hurdle. In addition, considering the trouble in #349 and #350, I have created another PR #351 to document our current knowledge regarding this issue. |
Re (1): now that npm is part of Microsoft, I'll ask around to see if I can find a contact. They were separate companies when I wrote the workaround. |
The assertion is not a rule, so it cannot be bypassed in DT config.
Both are published to NPM registry already.
Required for:
DefinitelyTyped/DefinitelyTyped#56874
DefinitelyTyped/DefinitelyTyped#56875
Thanks!
/cc @LinqLover