Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

When package names match the older-version pattern #308

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jablko
Copy link
Contributor

@jablko jablko commented Sep 4, 2020

The current implementation rejects package names that match /^v\d+(\.\d+)?$/. It complains:

Error: Since this type definition includes a header (a comment starting with // Type definitions for), assumed this was a DefinitelyTyped package.
But it is not in a DefinitelyTyped/types/xxx directory: /home/vsts/work/1/s/types/v8

however it clearly is in a "types" directory.

The proposed change would

  • continue to allow "types" grandchildren only if they match the older-version pattern
  • allow all "types" children, not just those that don't match it

@jablko jablko marked this pull request as ready for review September 4, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant