This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somewhat related to microsoft/types-publisher#708, the inclusion of test files in tsconfig.json means that dtslint might miss a library that errors on import, if a test file contains a
/// <reference types="..." />
that the library errors without.DefinitelyTyped/DefinitelyTyped#44178 corrects some examples of this.
The test files aren't normally part of users' builds, when users consume the declarations (the test files aren't even distributed in DefinitelyTyped
@types
packages). This change is an attempt to confirm that, as well as the tests passing, the declarations are importable by themselves.The
fileNames.filter(fileName => fileName.endsWith(".d.ts")
logic, to exclude the test files from the source files, comes from https://github.com/microsoft/types-publisher/blob/dd69e3b816be1600d7bec25919c4fe07826573c8/src/lib/module-info.ts#L165-L169I confirmed that this change does catch at least each of the cases addressed in DefinitelyTyped/DefinitelyTyped#44178, e.g.