Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

expect-type should allow tsconfig options from new versions of typescript #348

Open
sandersn opened this issue Oct 25, 2021 · 4 comments
Open
Assignees

Comments

@sandersn
Copy link
Member

Example: exactOptionalPropertyTypes only works in 4.4, but it should be required in all tsconfigs on DT even though older compilers won't recognise it.
expect-type should remove new flags from tsconfig when testing old versions.

@sandersn sandersn self-assigned this Oct 25, 2021
@sokarax
Copy link

sokarax commented Oct 31, 2021

Example: exactOptionalPropertyTypes only works in 4.4, but it should be required in all tsconfigs on DT even though older compilers won't recognise it.

expect-type should remove new flags from tsconfig when testing old versions.

Remove

@OliverJAsh
Copy link
Contributor

Note this is preventing me from writing a test for DefinitelyTyped/DefinitelyTyped#57463.

@sandersn
Copy link
Member Author

sandersn commented Dec 1, 2021

This is my DT duty week and this is on my list to fix. So maybe I'll have a fix soon!

@sandersn
Copy link
Member Author

sandersn commented Dec 7, 2021

@OliverJAsh I just published a new version of DefinitelyTyped-tools, so it should be available for DT PRs in a few minutes.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants