Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update tslint to 6.1.1 #285

Closed
wants to merge 2 commits into from
Closed

Conversation

Maxim-Mazurok
Copy link

Fixes #284

Also, typescript got updated from 3.9.0-dev.20200327 to 3.9.0-dev.20200422

and dtslint version in package-lock.json now synced with the version from package.json (3.4.0 -> 3.4.1)

@msftclas
Copy link

msftclas commented Apr 22, 2020

CLA assistant check
All CLA requirements met.

@sandersn
Copy link
Member

Can you test this with Definitely Typed? Clone Definitely Typed, npm install and then I think you need to npm link dtslint? I'm not sure about that last step.

Then you'll need to iterate over all directories running npm run lint types/$d and make sure there aren't any new errors compared to the current version.

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please test on Definitely Typed.

@Maxim-Mazurok
Copy link
Author

tslint is no longer referenced in package.json, dtslint uses "latest" version, and there's no pacakge-lock.json anymore.
So, this PR is obsolete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tslint is outdated
3 participants