Merge pull request #196 from Microsoft/forbid-npm-banned-words

sandersn · web-flow · commit 54599403097b · 2019-02-08T09:48:54.000-08:00
Forbid npm-banned words
diff --git a/src/checks.ts b/src/checks.ts
@@ -17,6 +17,11 @@ export async function checkPackageJson(
         }
         return;
     }
+    if (/download/.test(dirPath)) {
+        // Since npm won't release their banned-words list, we'll have to manually add to this list.
+        throw new Error(`${dirPath}: Contains the word 'download', which is banned by npm.`);
+    }
+
     const pkgJson = await readJson(pkgJsonPath) as {};
 
     if ((pkgJson as any).private !== true) {

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,11 @@ export async function checkPackageJson(`
`17`	`17`	`}`
`18`	`18`	`return;`
`19`	`19`	`}`
	`20`	`+ if (/download/.test(dirPath)) {`
	`21`	`+ // Since npm won't release their banned-words list, we'll have to manually add to this list.`
	`22`	+ throw new Error(`${dirPath}: Contains the word 'download', which is banned by npm.`);
	`23`	`+ }`
	`24`	`+`
`20`	`25`	`const pkgJson = await readJson(pkgJsonPath) as {};`
`21`	`26`
`22`	`27`	`if ((pkgJson as any).private !== true) {`