Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop databse include name #66

Closed
wants to merge 1 commit into from
Closed

drop databse include name #66

wants to merge 1 commit into from

Conversation

dataders
Copy link
Contributor

fixes: #65

@dataders
Copy link
Contributor Author

dataders commented Oct 20, 2021

@jtcohen6 do you see anything here that's off? I thought I did everything I needed to, but relations are still rendered with the database name... I'm stumped. Maybe it has to do with SQLServerAdapter class not having it's own Relation class? idk I'm sure I'm missing something silly

Also does the Include policy apply also to the source and ref macros?

@jtcohen6
Copy link
Contributor

@swanderz The change here looks right on to me. It looks like CI might be failing for a different reason?

Could not connect to db: ('HY000', '[HY000] [Microsoft][ODBC Driver 17 for SQL Server][SQL Server]Cannot connect to database when it is paused. (40892) (SQLDriverConnect)')

Yes, the include policy will also apply to source and ref, since they return Relation objects.

@dataders
Copy link
Contributor Author

@alieus can you try installing this branch and checking to see if the db name is include in the compiled SQL files? I tried yesterday and it kept showing up...

@alieus
Copy link
Contributor

alieus commented Oct 21, 2021

@swanderz I just checked and you're right. The db name is still included:

image

@av1nash
Copy link

av1nash commented Mar 15, 2022

@dataders This PR can be discarded. A workaround to not include database name can be implemented using macros.

@dataders dataders closed this Oct 7, 2022
@prdpsvs prdpsvs deleted the no_dbname branch May 21, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

including database name in relation causes issue w/ SSDT
4 participants