Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Actions workflow cannot build arm32 after updating Windows SDK #1454

Merged
merged 3 commits into from
Nov 19, 2024

Conversation

dmachaj
Copy link
Contributor

@dmachaj dmachaj commented Nov 18, 2024

Closes #1452

arm32 is not supported anymore by Windows. There has not been a native arm32 OS since before Win11. The wow32 backcompat on arm64 devices to run arm32 programs was removed with Win11 24H2. Most notably, the ability to build arm32 with newer SDKs and toolsets has seemingly been removed. This is now breaking the CI build.

The easiest fix is to simply remove arm32 support.

See: https://www.microsoft.com/en-us/windows/windows-11-specifications?r=1#table3

See: https://learn.microsoft.com/en-us/windows/arm/arm32-to-arm64
"Windows devices running on an Arm processor (for example, Snapdragon processors from Qualcomm) will no longer support AArch32 (Arm32). This change impacts Universal Windows Platform apps that presently target AArch32 (Arm32). Support for 32-bit Arm versions of applications will be removed in a future release of Windows 11.. System binaries for ARM32 support (present in the sysarm32 folder) will also be removed."

See: https://blogs.windows.com/windows-insider/2023/07/12/announcing-windows-11-insider-preview-build-25905/
(July 2023)
"Starting in this Insider Preview build in the Canary Channel, we have removed support for Arm32 UWP applications from Windows on Arm, as documented here: Windows 11 Specs and System Requirements. After the OS upgrade, any installed Arm32 applications will no longer launch on your device. Note that this does not affect Arm64 applications."

jonwis
jonwis previously approved these changes Nov 18, 2024
nuget/Microsoft.Windows.CppWinRT.nuspec Show resolved Hide resolved
@jonwis
Copy link
Member

jonwis commented Nov 18, 2024

Might find and reference the right support KB for removal, just for posterity - https://support.microsoft.com/en-us/topic/windows-11-version-24h2-update-history-0929c747-1815-4543-8461-0160d16f15e5 is the latest, in case that helps.

@dmachaj
Copy link
Contributor Author

dmachaj commented Nov 18, 2024

Might find and reference the right support KB for removal, just for posterity - https://support.microsoft.com/en-us/topic/windows-11-version-24h2-update-history-0929c747-1815-4543-8461-0160d16f15e5 is the latest, in case that helps.

Updated the description of the PR with some links

Copy link
Contributor

@sylveon sylveon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fact this is over 2000 lines of vcxproj changes makes me sad. Really wish the project format was better.

@dmachaj
Copy link
Contributor Author

dmachaj commented Nov 19, 2024

The fact this is over 2000 lines of vcxproj changes makes me sad. Really wish the project format was better.

Yeahhhhhhh. I can comprehend wanting the vcxprojs to be more independent (vs. centralizing in some far-flung props/targets files) but the duplication is pretty extreme. Even within the vcxproj's there is a ton of identical content for each supported build flavor. That could be refactored to be 5-10x less lines of XML but that will have to wait for another day.

@dmachaj dmachaj merged commit 2aed347 into master Nov 19, 2024
75 checks passed
@dmachaj dmachaj deleted the user/dmachaj/remove-arm32 branch November 19, 2024 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub Actions workflow cannot build arm32 after updating Windows SDK min version
3 participants