Skip to content

Conversation

@cshung
Copy link
Contributor

@cshung cshung commented Jan 9, 2025

This PR is meant to support dotnet/diagnostics#5090.

This PR is the clrmd side of the work, this exposes a new field so that the debugger can display the information.
There are two more PRs on different repos to support this:

On runtime: dotnet/runtime#107115
On diagnostics: dotnet/diagnostics#5164

Copy link

@mikem8361 mikem8361 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @leculver do you want to review?

Copy link
Contributor

@leculver leculver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leculver leculver merged commit 59e8f8b into microsoft:main Jan 13, 2025
8 checks passed
mikem8361 pushed a commit to dotnet/diagnostics that referenced this pull request Jan 24, 2025
This PR is meant to support
#5090.

This PR is the diagnostics side of the work, this exposes a new field so
that the debugger can display the information.
There are two more PRs on different repos to support this:

The code won't compile until the clrmd dependency is consumed.

On runtime: dotnet/runtime#107115
On clrmd: microsoft/clrmd#1301
@cshung cshung deleted the public/datas-debugger branch March 14, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants