Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update partitionKey path definitions for cosmosDatabase containers. #240

Merged
merged 8 commits into from
Aug 28, 2023
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions scripts/deploy/main.bicep
dluc marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -637,7 +637,7 @@ resource messageContainer 'Microsoft.DocumentDB/databaseAccounts/sqlDatabases/co
}
partitionKey: {
paths: [
'/id'
'/chatId'
crickman marked this conversation as resolved.
Show resolved Hide resolved
]
kind: 'Hash'
version: 2
Expand Down Expand Up @@ -699,7 +699,7 @@ resource participantContainer 'Microsoft.DocumentDB/databaseAccounts/sqlDatabase
}
partitionKey: {
paths: [
'/id'
'/chatId'
]
kind: 'Hash'
version: 2
Expand Down Expand Up @@ -730,7 +730,7 @@ resource memorySourcesContainer 'Microsoft.DocumentDB/databaseAccounts/sqlDataba
}
partitionKey: {
paths: [
'/id'
'/chatId'
]
kind: 'Hash'
version: 2
Expand Down
8 changes: 4 additions & 4 deletions webapi/Controllers/ChatHistoryController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ public async Task<IActionResult> CreateChatSessionAsync(
public async Task<IActionResult> GetChatSessionByIdAsync(Guid chatId)
{
ChatSession? chat = null;
if (await this._sessionRepository.TryFindByIdAsync(chatId.ToString(), v => chat = v))
if (await this._sessionRepository.TryFindByIdAsync(chatId.ToString(), callback: v => chat = v))
{
return this.Ok(chat);
}
Expand Down Expand Up @@ -156,7 +156,7 @@ public async Task<IActionResult> GetAllChatSessionsAsync(string userId)
foreach (var chatParticipant in chatParticipants)
{
ChatSession? chat = null;
if (await this._sessionRepository.TryFindByIdAsync(chatParticipant.ChatId, v => chat = v))
if (await this._sessionRepository.TryFindByIdAsync(chatParticipant.ChatId, callback: v => chat = v))
{
chats.Add(chat!);
}
Expand Down Expand Up @@ -231,7 +231,7 @@ public async Task<IActionResult> EditChatSessionAsync(
}

ChatSession? chat = null;
if (await this._sessionRepository.TryFindByIdAsync(chatId, v => chat = v))
if (await this._sessionRepository.TryFindByIdAsync(chatId, callback: v => chat = v))
{
chat!.Title = chatParameters.Title ?? chat!.Title;
chat!.SystemDescription = chatParameters.SystemDescription ?? chat!.SystemDescription;
Expand Down Expand Up @@ -260,7 +260,7 @@ public async Task<ActionResult<IEnumerable<MemorySource>>> GetSourcesAsync(
{
this._logger.LogInformation("Get imported sources of chat session {0}", chatId);

if (await this._sessionRepository.TryFindByIdAsync(chatId.ToString(), v => _ = v))
if (await this._sessionRepository.TryFindByIdAsync(chatId.ToString()))
dluc marked this conversation as resolved.
Show resolved Hide resolved
{
var sources = await this._sourceRepository.FindByChatIdAsync(chatId.ToString());
return this.Ok(sources);
Expand Down
2 changes: 1 addition & 1 deletion webapi/Controllers/ChatMemoryController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ public async Task<IActionResult> GetSemanticMemoriesAsync(
var sanitizedMemoryName = memoryName.Replace(Environment.NewLine, string.Empty, StringComparison.Ordinal);

// Make sure the chat session exists.
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => _ = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId))
{
this._logger.LogWarning("Chat session: {0} does not exist.", sanitizedChatId);
return this.BadRequest($"Chat session: {sanitizedChatId} does not exist.");
Expand Down
4 changes: 2 additions & 2 deletions webapi/Controllers/ChatParticipantController.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public async Task<IActionResult> JoinChatAsync(
string userId = authInfo.UserId;

// Make sure the chat session exists.
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => _ = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId))
{
return this.BadRequest("Chat session does not exist.");
}
Expand Down Expand Up @@ -97,7 +97,7 @@ public async Task<IActionResult> JoinChatAsync(
public async Task<IActionResult> GetAllParticipantsAsync(Guid chatId)
{
// Make sure the chat session exists.
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId.ToString(), v => _ = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId.ToString()))
{
return this.NotFound("Chat session does not exist.");
}
Expand Down
7 changes: 7 additions & 0 deletions webapi/Models/Storage/ChatMessage.cs
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
using System.Collections.Generic;
using System.Globalization;
using System.Text.Json;
using System.Text.Json.Serialization;
using CopilotChat.WebApi.Models.Response;
using CopilotChat.WebApi.Storage;

Expand Down Expand Up @@ -109,6 +110,12 @@ public enum ChatMessageType
/// </summary>
public Dictionary<string, int>? TokenUsage { get; set; }

/// <summary>
/// The partition key for the source.
/// </summary>
[JsonIgnore]
public string Partition => this.ChatId;

/// <summary>
/// Create a new chat message. Timestamp is automatically generated.
/// </summary>
Expand Down
7 changes: 7 additions & 0 deletions webapi/Models/Storage/ChatParticipant.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.

using System;
using System.Text.Json.Serialization;
using CopilotChat.WebApi.Storage;

namespace CopilotChat.WebApi.Models.Storage;
Expand All @@ -26,6 +27,12 @@ public class ChatParticipant : IStorageEntity
/// </summary>
public string ChatId { get; set; }

/// <summary>
/// The partition key for the source.
/// </summary>
[JsonIgnore]
public string Partition => this.ChatId;
crickman marked this conversation as resolved.
Show resolved Hide resolved

public ChatParticipant(string userId, string chatId)
{
this.Id = Guid.NewGuid().ToString();
Expand Down
7 changes: 7 additions & 0 deletions webapi/Models/Storage/ChatSession.cs
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
// Copyright (c) Microsoft. All rights reserved.

using System;
using System.Text.Json.Serialization;
using CopilotChat.WebApi.Storage;

namespace CopilotChat.WebApi.Models.Storage;
Expand Down Expand Up @@ -37,6 +38,12 @@ public class ChatSession : IStorageEntity
/// </summary>
public double MemoryBalance { get; set; } = 0.5;

/// <summary>
/// The partition key for the session.
/// </summary>
[JsonIgnore]
public string Partition => this.Id;

/// <summary>
/// Initializes a new instance of the <see cref="ChatSession"/> class.
/// </summary>
Expand Down
6 changes: 6 additions & 0 deletions webapi/Models/Storage/MemorySource.cs
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,12 @@ public class MemorySource : IStorageEntity
[JsonPropertyName("tokens")]
public long Tokens { get; set; } = 0;

/// <summary>
/// The partition key for the source.
/// </summary>
[JsonIgnore]
public string Partition => this.ChatId;

/// <summary>
/// Empty constructor for serialization.
/// </summary>
Expand Down
6 changes: 3 additions & 3 deletions webapi/Skills/ChatSkills/ChatSkill.cs
Original file line number Diff line number Diff line change
Expand Up @@ -564,7 +564,7 @@ private async Task<string> AcquireExternalInformationAsync(SKContext context, st
private async Task<ChatMessage> SaveNewMessageAsync(string message, string userId, string userName, string chatId, string type)
{
// Make sure the chat exists.
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => _ = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId))
{
throw new ArgumentException("Chat session does not exist.");
}
Expand Down Expand Up @@ -597,7 +597,7 @@ private async Task<ChatMessage> SaveNewMessageAsync(string message, string userI
private async Task<ChatMessage> SaveNewResponseAsync(string response, string prompt, string chatId, string userId, Dictionary<string, int>? tokenUsage)
{
// Make sure the chat exists.
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => _ = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId))
{
throw new ArgumentException("Chat session does not exist.");
}
Expand Down Expand Up @@ -775,7 +775,7 @@ private async Task UpdateBotResponseStatusOnClient(string chatId, string status)
private async Task SetSystemDescriptionAsync(string chatId)
{
ChatSession? chatSession = null;
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => chatSession = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, callback: v => chatSession = v))
{
throw new ArgumentException("Chat session does not exist.");
}
Expand Down
2 changes: 1 addition & 1 deletion webapi/Skills/ChatSkills/SemanticChatMemorySkill.cs
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ public async Task<string> QueryMemoriesAsync(
ISemanticTextMemory textMemory)
{
ChatSession? chatSession = null;
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, v => chatSession = v))
if (!await this._chatSessionRepository.TryFindByIdAsync(chatId, callback: v => chatSession = v))
{
throw new ArgumentException($"Chat session {chatId} not found.");
}
Expand Down
6 changes: 3 additions & 3 deletions webapi/Storage/CosmosDbContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,11 @@ public async Task DeleteAsync(T entity)
throw new ArgumentOutOfRangeException(nameof(entity.Id), "Entity Id cannot be null or empty.");
}

await this._container.DeleteItemAsync<T>(entity.Id, new PartitionKey(entity.Id));
await this._container.DeleteItemAsync<T>(entity.Id, new PartitionKey(entity.Partition));
}

/// <inheritdoc/>
public async Task<T> ReadAsync(string entityId)
public async Task<T> ReadAsync(string entityId, string partitionKey)
{
if (string.IsNullOrWhiteSpace(entityId))
{
Expand All @@ -83,7 +83,7 @@ public async Task<T> ReadAsync(string entityId)

try
{
var response = await this._container.ReadItemAsync<T>(entityId, new PartitionKey(entityId));
var response = await this._container.ReadItemAsync<T>(entityId, new PartitionKey(partitionKey));
return response.Resource;
}
catch (CosmosException ex) when (ex.StatusCode == HttpStatusCode.NotFound)
Expand Down
2 changes: 1 addition & 1 deletion webapi/Storage/FileSystemContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ public Task DeleteAsync(T entity)
}

/// <inheritdoc/>
public Task<T> ReadAsync(string entityId)
public Task<T> ReadAsync(string entityId, string partitionKey)
{
if (string.IsNullOrWhiteSpace(entityId))
{
Expand Down
8 changes: 5 additions & 3 deletions webapi/Storage/IRepository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,16 @@ public interface IRepository<T> where T : IStorageEntity
/// Finds an entity by its id.
/// </summary>
/// <param name="id">Id of the entity.</param>
/// <param name="partition">Partition of the entity.</param>
/// <returns>An entity</returns>
Task<T> FindByIdAsync(string id);
Task<T> FindByIdAsync(string id, string partition);

/// <summary>
/// Tries to find an entity by its id.
/// </summary>
/// <param name="id">Id of the entity.</param>
/// <param name="entity">The entity delegate. Note async methods don't support ref or out parameters.</param>
/// <param name="partition">Partition of the entity.</param>
/// <param name="callback">The entity delegate. Note async methods don't support ref or out parameters.</param>
/// <returns>True if the entity was found, false otherwise.</returns>
Task<bool> TryFindByIdAsync(string id, Action<T?> entity);
Task<bool> TryFindByIdAsync(string id, string partition, Action<T?> callback);
}
3 changes: 2 additions & 1 deletion webapi/Storage/IStorageContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ public interface IStorageContext<T> where T : IStorageEntity
/// Read an entity from the storage context by id.
/// </summary>
/// <param name="entityId">The entity id.</param>
/// <param name="partitionKey">The entity partition</param>
/// <returns>The entity.</returns>
Task<T> ReadAsync(string entityId);
Task<T> ReadAsync(string entityId, string partitionKey);

/// <summary>
/// Create an entity in the storage context.
Expand Down
2 changes: 2 additions & 0 deletions webapi/Storage/IStorageEntity.cs
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ namespace CopilotChat.WebApi.Storage;
public interface IStorageEntity
{
string Id { get; set; }

string Partition { get; }
}
9 changes: 4 additions & 5 deletions webapi/Storage/Repository.cs
Original file line number Diff line number Diff line change
Expand Up @@ -42,22 +42,21 @@ public Task DeleteAsync(T entity)
}

/// <inheritdoc/>
public Task<T> FindByIdAsync(string id)
public Task<T> FindByIdAsync(string id, string? partition = null)
{
return this.StorageContext.ReadAsync(id);
return this.StorageContext.ReadAsync(id, partition ?? id);
}

/// <inheritdoc/>
public async Task<bool> TryFindByIdAsync(string id, Action<T?> entity)
public async Task<bool> TryFindByIdAsync(string id, string? partition = null, Action<T?>? callback = null)
crickman marked this conversation as resolved.
Show resolved Hide resolved
{
try
{
entity(await this.FindByIdAsync(id));
callback?.Invoke(await this.FindByIdAsync(id, partition ?? id));
return true;
}
catch (Exception ex) when (ex is ArgumentOutOfRangeException || ex is KeyNotFoundException)
{
entity(default);
return false;
}
}
Expand Down
2 changes: 1 addition & 1 deletion webapi/Storage/VolatileContext.cs
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public Task DeleteAsync(T entity)
}

/// <inheritdoc/>
public Task<T> ReadAsync(string entityId)
public Task<T> ReadAsync(string entityId, string partitionKey)
{
if (string.IsNullOrWhiteSpace(entityId))
{
Expand Down