Missing LICENSE files and invalid package.json #3192
Labels
Area: SDK
General SDK issues that don't clearly map to other areas (e.g.: helper methods)
backlog
The issue is out of scope for the current iteration but it will be evaluated in a future release.
Bot Services
Required for internal Azure reporting. Do not delete. Do not change color.
customer-replied-to
Indicates that the team has replied to the issue reported by the customer. Do not delete.
customer-reported
Issue is created by anyone that is not a collaborator in the repository.
ExemptFromDailyDRIReport
Use this label to exclude the issue from the DRI report.
P2
Nice to have
Size: S
The issue is simple and well understood, it will take a day or less to complete
The workspaces in the
libraries
directory are missing LICENSE files (e.g. here). Although it's strictly not necessary as there is one at the root of the repo, it would make it clearer for users to have the LICENSE file alongside the package.json. This is fairly common practice (e.g. Missing LICENSE file AzureAD/microsoft-authentication-library-for-js#2864)The package.json files for the packages in the
libraries
directory have version which don't match the tags of the code, or the root level package.json. (See package.json where the version is the file is 4.1.6, the tag of the code is 4.11.0. I understand that you are using lerna to manage versions, but I would suggest making sure the version listed in the code at the tag agrees with whatever lerna uses (even if the workspace package.json doesn't have a version - it's better for it not be wrong). This would make it less confusing for those new to your project to understand!The text was updated successfully, but these errors were encountered: