Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LICENSE files and invalid package.json #3192

Closed
j-buckland opened this issue Jan 15, 2021 · 2 comments · Fixed by #4169
Closed

Missing LICENSE files and invalid package.json #3192

j-buckland opened this issue Jan 15, 2021 · 2 comments · Fixed by #4169
Assignees
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P2 Nice to have Size: S The issue is simple and well understood, it will take a day or less to complete

Comments

@j-buckland
Copy link

  • The workspaces in the libraries directory are missing LICENSE files (e.g. here). Although it's strictly not necessary as there is one at the root of the repo, it would make it clearer for users to have the LICENSE file alongside the package.json. This is fairly common practice (e.g. Missing LICENSE file AzureAD/microsoft-authentication-library-for-js#2864)

  • The package.json files for the packages in the libraries directory have version which don't match the tags of the code, or the root level package.json. (See package.json where the version is the file is 4.1.6, the tag of the code is 4.11.0. I understand that you are using lerna to manage versions, but I would suggest making sure the version listed in the code at the tag agrees with whatever lerna uses (even if the workspace package.json doesn't have a version - it's better for it not be wrong). This would make it less confusing for those new to your project to understand!

@j-buckland j-buckland added bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 15, 2021
@joshgummersall joshgummersall self-assigned this Jan 15, 2021
@joshgummersall joshgummersall added Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) P2 Nice to have Size: S The issue is simple and well understood, it will take a day or less to complete and removed bug Indicates an unexpected problem or an unintended behavior. needs-triage The issue has just been created and it has not been reviewed by the team. labels Jan 15, 2021
@joshgummersall
Copy link
Contributor

Thanks for reporting, @j-buckland! I've added the issue to our backlog.

@joshgummersall joshgummersall added the backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. label Jan 15, 2021
@tracyboehrer tracyboehrer added Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. labels Jan 15, 2021
@srinaath srinaath added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Feb 2, 2021
@joshgummersall joshgummersall removed the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Mar 30, 2021
@lauren-mills lauren-mills added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label Apr 12, 2021
@joshgummersall joshgummersall removed the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label May 4, 2021
@joshgummersall joshgummersall added the ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. label May 4, 2021
@mrivera-ms mrivera-ms assigned JuanAr and unassigned joshgummersall Mar 3, 2022
@sw-joelmut
Copy link
Collaborator

@mrivera-ms in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: SDK General SDK issues that don't clearly map to other areas (e.g.: helper methods) backlog The issue is out of scope for the current iteration but it will be evaluated in a future release. Bot Services Required for internal Azure reporting. Do not delete. Do not change color. customer-replied-to Indicates that the team has replied to the issue reported by the customer. Do not delete. customer-reported Issue is created by anyone that is not a collaborator in the repository. ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. P2 Nice to have Size: S The issue is simple and well understood, it will take a day or less to complete
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants