Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PORT] Add unit test for CancelAllDialogs and fix eventName and eventValue null #1892

Closed
tomlm opened this issue Mar 11, 2020 · 0 comments · Fixed by #2049
Closed

[PORT] Add unit test for CancelAllDialogs and fix eventName and eventValue null #1892

tomlm opened this issue Mar 11, 2020 · 0 comments · Fixed by #2049
Assignees
@Stevenic
Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Milestone
R9

Comments

@tomlm
Copy link
Contributor

tomlm commented Mar 11, 2020 •
edited by christopheranderson
Loading

Port this change from botbuilder-dotnet/master branch:
microsoft/botbuilder-dotnet#3536

#3534
Fixes CancelAllDialogs.eventName and eventValue is valid to be null

Changed projects

  • Microsoft.Bot.Builder.Dialogs.Adaptive
  • Microsoft.Bot.Builder.Dialogs
  • Microsoft.Bot.Builder.Dialogs.Adaptive.Tests

[R9,adaptive,bug,test]
@github-actions github-actions bot added adaptive bug Indicates an unexpected problem or an unintended behavior. R8 Release 8 - March 16th, 2020 labels Mar 11, 2020
@Kaiqb Kaiqb removed the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@github-actions github-actions bot added the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@tomlm tomlm added R9 Release 9 - May 15th, 2020 and removed R8 Release 8 - March 16th, 2020 labels Mar 11, 2020
@github-actions github-actions bot added the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@Kaiqb Kaiqb removed the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@github-actions github-actions bot added the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@Kaiqb Kaiqb removed the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@github-actions github-actions bot added the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@Kaiqb Kaiqb removed the R8 Release 8 - March 16th, 2020 label Mar 11, 2020
@github-actions github-actions bot added the test label Mar 12, 2020
@github-actions github-actions bot added the test label Mar 12, 2020
@github-actions github-actions bot added the test label Mar 12, 2020
@cleemullins cleemullins added the P1 Painful if we don't fix, won't block releasing label Apr 8, 2020
@chon219 chon219 mentioned this issue Apr 16, 2020
Merged
@munozemilio munozemilio added this to the R9 milestone Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stevenic Stevenic

Labels
bug Indicates an unexpected problem or an unintended behavior. P1 Painful if we don't fix, won't block releasing R9 Release 9 - May 15th, 2020
Projects
None yet
Milestone
R9
Development

Successfully merging a pull request may close this issue.

Added test case for CancelAllDialogs microsoft/botbuilder-js
6 participants
@Stevenic @cleemullins @christopheranderson @tomlm @Kaiqb @munozemilio