Skip to content

The application insights readme has some dead links #1118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
benbrown opened this issue Aug 21, 2019 · 1 comment · Fixed by #1487
Closed

The application insights readme has some dead links #1118

benbrown opened this issue Aug 21, 2019 · 1 comment · Fixed by #1487
Assignees
@munozemilio
Labels
bug Indicates an unexpected problem or an unintended behavior. R7 Release 7 - December 10th, 2019
Milestone
R7

Comments

@benbrown
Copy link
Contributor

Describe the bug

This page links to samples that no longer exist:
https://github.com/microsoft/botbuilder-js/tree/master/libraries/botbuilder-applicationinsights

To Reproduce

Click on the qnamaker or luis examples within the body or the footer of this document. It leads to 404s!

Expected behavior

We should link to useful examples for applying App Insights to these recognizers.

[bug]
@Zerryth
Copy link
Contributor

Zerryth commented Aug 21, 2019

Links used to go to:

image
and
image

So looks like fixing of this readmes bug depends on completion of this samples issue tracking building JS AppInsights samples

@cleemullins cleemullins added the R7 Release 7 - December 10th, 2019 label Nov 26, 2019
@cleemullins cleemullins assigned Kaiqb and munozemilio and unassigned Kaiqb Nov 26, 2019
@munozemilio munozemilio mentioned this issue Dec 9, 2019
Merged
@munozemilio munozemilio added this to the R7 milestone Jul 1, 2020
@github-actions github-actions bot added the bug Indicates an unexpected problem or an unintended behavior. label Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@munozemilio munozemilio

Labels
bug Indicates an unexpected problem or an unintended behavior. R7 Release 7 - December 10th, 2019
Projects
None yet
Milestone
R7
Development

Successfully merging a pull request may close this issue.

Remove dead links to unexisting AppInsights sample microsoft/botbuilder-js
5 participants
@benbrown @cleemullins @Kaiqb @Zerryth @munozemilio