Update SqlPackageOnTargetMachines.ps1#1208
Closed
phalpin wants to merge 1 commit into
Closed
Conversation
Remove --% simple parsing directive. This causes Illegal characters in path errors from sqlpackage when used via Invoke-Command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove --% simple parsing directive. This causes Illegal characters in path errors from sqlpackage when used via Invoke-DacpacDeployment. Removing --% appears to alleviate the problem and continues to work in ps5 + pscore. Seems to be the only usage of this method.
Don't know all of the use cases for this, so feel free to nuke this PR if this will break something known, but I've tried with and without spaces, it appears to work in both PS5 and PS Core (7.3.8 specifically)