Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: Microsoft.VCToolsVersion.v143.default.props contains wrong version #4554

Closed
1 of 4 tasks
jbrezina opened this issue Dec 4, 2023 · 5 comments
Closed
1 of 4 tasks

Comments

@jbrezina
Copy link

jbrezina commented Dec 4, 2023

What happened?

As described in this issue, there is a wrong version contained within the file c:\Program Files\Microsoft Visual Studio\2022\Enterprise\VC\Auxiliary\Build\Microsoft.VCToolsVersion.v143.default.props. The version should be 14.38.33130 but it is 14.37.32822.

Versions

Agent name: 'Hosted Agent'
Agent machine name: 'fv-az290-93'
Current agent version: '3.230.0'
Operating System
Microsoft Windows Server 2022
10.0.20348
Datacenter
Runner Image
Image: windows-2022
Version: 20231126.1.0
Included Software: https://github.com/actions/runner-images/blob/win22/20231126.1/images/windows/Windows2022-Readme.md
Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F20231126.1
Runner Image Provisioner
2.0.321.1

Environment type (Please select at least one enviroment where you face this issue)

  • Self-Hosted
  • Microsoft Hosted
  • VMSS Pool
  • Container

Azure DevOps Server type

dev.azure.com (formerly visualstudio.com)

Azure DevOps Server Version (if applicable)

No response

Operation system

Windows Server 2022 10.0.20348

Version controll system

No response

Relevant log output

No response

@DenisNikulin5
Copy link
Contributor

Hi @jbrezina thanks for reporting! We are working on more prioritized issues at the moment, but will get back to this one soon.

@jbrezina
Copy link
Author

jbrezina commented Jan 8, 2024

Hi, any updates on this please? This is a one line fix and it is a blocker for c++ pipelines to work correctly.. this issue is regularly recurring so it would be great, if you have any check on this though

antonfirsov added a commit to dotnet/runtime that referenced this issue Mar 24, 2024
#100145)

Workaround for microsoft/azure-pipelines-agent#4554. Microsoft.VCToolsVersion.v143.default.txt contains the wrong MSVC version, deleting the file makes vcvarsall.bat fall back to Microsoft.VCToolsVersion.default.txt, which has the correct version.
@antonfirsov
Copy link
Member

@DenisNikulin5 FYI one of the dotnet/runtime pipelines was also broken because of this, which was really nasty to diagnose. We had to go with a workaround, would be nice to get rid of it.

@jbrezina
Copy link
Author

jbrezina commented Apr 3, 2024

@DenisNikulin5 Hi, it would be great if you find the time to fix this one line so everyone does not have to investigate this issue and spend a lot of men-hours to find the solution as described here Latest Visual Studio version (17.9.1) causes a linker error calling thread::sleep_for from a static library linked to Unreal and then implement the workaround until you find the time to fix this.
Also it would be great if you somehow automate the check for this as it is a repetitive issue.

@DenisNikulin5
Copy link
Contributor

Hi @jbrezina. We're back to your problem. As I can see the azure cloud image (windows-2022) has an issue.
But this repo is only related to the agent itself, so please recreate the issue in https://github.com/actions/runner-images.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants