Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: KEDA version update to allow scaling with GitHub App toward GitHub Enterprise Server. #1147

Closed
Hi-Fi opened this issue Apr 17, 2024 · 2 comments
Labels
enhancement New feature or request Needs: triage 🔍 Pending a first pass to read, tag, and assign

Comments

@Hi-Fi
Copy link

Hi-Fi commented Apr 17, 2024

Is your feature request related to a problem? Please describe.
We're using GitHub Enterprise Server (GHES), and would like to use GitHub App for runner authentication. For runner side that works fine, but for scaling side currently used KEDA version (2.12.1) doesn't set GitHub API URL correctly to PEM handling part. It's fixed at 2.13.0 release (issue kedacore/keda#5387)

Describe the solution you'd like.
ACA environment to use newer KEDA version (current one 2.13.1).

Describe alternatives you've considered.
Currently we have to use PAT for the authentication, but being able to impersonate registration would be good thing. Other option would be to use bot accounts to get those PATs, but it's also a bit dirty solution as there's native way to authenticate already supported by KEDA.

Additional context.
Runner process can authenticate already fine with PEM, using https://docs.github.com/en/apps/creating-github-apps/authenticating-with-a-github-app/generating-a-json-web-token-jwt-for-a-github-app#example-using-bash-to-generate-a-jwt to get the JWT and with that registration token for runner process.

@Hi-Fi Hi-Fi added the enhancement New feature or request label Apr 17, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: triage 🔍 Pending a first pass to read, tag, and assign label Apr 17, 2024
@tomkerkhove
Copy link
Member

@anthonychu I think this would be a good improvement, can you talk about it?

@Hi-Fi Hi-Fi changed the title Feature Request: KEDA version update to allos scaling with GitHub App toward GitHub Enterprise Server. Feature Request: KEDA version update to allow scaling with GitHub App toward GitHub Enterprise Server. Apr 22, 2024
@Hi-Fi
Copy link
Author

Hi-Fi commented Sep 24, 2024

KEDA version in ACA seems to be now 2.14.0, and scaling works fine with GitHub App.

@Hi-Fi Hi-Fi closed this as completed Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Needs: triage 🔍 Pending a first pass to read, tag, and assign
Projects
None yet
Development

No branches or pull requests

2 participants