Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add example of good doc sting to CONTRIBUTING.md #4464

Closed
gagb opened this issue Dec 2, 2024 · 3 comments · Fixed by #4880
Closed

Add example of good doc sting to CONTRIBUTING.md #4464

gagb opened this issue Dec 2, 2024 · 3 comments · Fixed by #4880
Assignees
Labels
documentation Improvements or additions to documentation
Milestone

Comments

@gagb
Copy link
Collaborator

gagb commented Dec 2, 2024

What feature would you like to be added?

Template and example for doc string that works well with the Sphinx theme.

Why is this needed?

To invite higher quality contributions.

@gagb gagb added the documentation Improvements or additions to documentation label Dec 2, 2024
@ekzhu ekzhu removed the needs-triage label Dec 2, 2024
@ekzhu ekzhu added this to the 0.4.0 milestone Dec 2, 2024
@gagb
Copy link
Collaborator Author

gagb commented Dec 3, 2024

Can we also have an etiquette whether system prompts and descriptions (usually long strings) should be set directly in the constructor. This can make the docs look busy as show below. Instead, we could use class variables. cc @afourney

Image

@afourney
Copy link
Member

afourney commented Dec 3, 2024

I feel like in the cases I looked at the documentation engine expanded the constants.

I do not believe all of those long prompts are actually specified directly in the constructors?

@gagb
Copy link
Collaborator Author

gagb commented Dec 11, 2024

I feel like in the cases I looked at the documentation engine expanded the constants.

I do not believe all of those long prompts are actually specified directly in the constructors?

The engine expands if the constant is used as the default. If None is used, it won't expand it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants