Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider removing azure openai automatic config property changes #4316

Closed
jackgerrits opened this issue Nov 22, 2024 · 0 comments · Fixed by #4853
Closed

Consider removing azure openai automatic config property changes #4316

jackgerrits opened this issue Nov 22, 2024 · 0 comments · Fixed by #4853
Milestone

Comments

@jackgerrits
Copy link
Member

jackgerrits commented Nov 22, 2024

The Azure OpenAI client does some parameter fixups as detailed in the below code block:

    copied_config["azure_deployment"] = copied_config.get("azure_deployment", config.get("model"))
    if copied_config["azure_deployment"] is not None:
        copied_config["azure_deployment"] = copied_config["azure_deployment"].replace(".", "")
    copied_config["azure_endpoint"] = copied_config.get("azure_endpoint", copied_config.pop("base_url", None))

https://github.com/microsoft/autogen/blob/grpc_optional/python/packages/autogen-core/src/autogen_core/components/models/_openai_client.py#L89-L90

  • maps "model" to "azure_deployment"
  • removes "." within the value of "azure_deployment"
  • maps "base_url" to "azure_endpoint"

This is legacy from the old LLM config list. However, to be honest I now feel like these fixups are surprising and confusing. If you are opting to use the Azure client, you likely know these values or are able to look them up. I feel like we should remove these fixups to make the configuration path more obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant