Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

register_factory should be a user-level API #3625

Closed
ekzhu opened this issue Oct 3, 2024 · 0 comments · Fixed by #4854
Closed

register_factory should be a user-level API #3625

ekzhu opened this issue Oct 3, 2024 · 0 comments · Fixed by #4854
Assignees
Labels
size-small takes 1-2 days
Milestone

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Oct 3, 2024

What feature would you like to be added?

The register_factory method in the core's AgentRuntime API should be a user-friendly API. This entails the following changes:

  1. type should be string or AgentType
  2. expected_types should be optional
  3. type and agent_factory should be positional arguments
  4. doc string

Why is this needed?

BaseAgent.register is not applicable in scenarios where the factory and subscriptions are registered separately with the runtime. For example, when importing a 3rd party agent class implementation, we cannot assume a default subscription on the agent class, and we would like to specify the subscription on our side.

@ekzhu ekzhu removed the needs-triage label Oct 3, 2024
@rysweet rysweet added this to the future milestone Oct 22, 2024
@jackgerrits jackgerrits modified the milestones: future, 0.4 Oct 22, 2024
@fniedtner fniedtner removed the feature label Oct 24, 2024
@jackgerrits jackgerrits added size-small takes 1-2 days and removed proj-core labels Oct 24, 2024
@jackgerrits jackgerrits self-assigned this Nov 20, 2024
@jackgerrits jackgerrits removed their assignment Dec 2, 2024
@ekzhu ekzhu modified the milestones: 0.4.0, 0.4.1 Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size-small takes 1-2 days
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants