Skip to content

[Feature Request]: Run docker tests on Github Workflow #1228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ekzhu opened this issue Jan 13, 2024 · 2 comments
Closed

[Feature Request]: Run docker tests on Github Workflow #1228

ekzhu opened this issue Jan 13, 2024 · 2 comments

Comments

@ekzhu
Copy link
Collaborator

ekzhu commented Jan 13, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Be able to run docker tests on GitHub Workflow. Currently some docker tests are skipped in the build workflow due to the docker not being installed but this can cause bugs to leak through.

This is related to discussion in several issues:
#1154
#1127
#1103

Describe the solution you'd like

No response

Additional context

No response
@ekzhu
Copy link
Collaborator Author

ekzhu commented Jan 13, 2024

Could you be more specific? They are not skipped in my understanding.

Some docker tests are skipped due to docker not installed. Updated.

@ekzhu ekzhu mentioned this issue Jan 13, 2024
Merged
3 tasks
@ekzhu ekzhu added the dev label Jan 14, 2024
@ekzhu
Copy link
Collaborator Author

ekzhu commented Mar 28, 2024

This is done with the docker tests now running in action.

@ekzhu ekzhu closed this as completed Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ekzhu