Skip to content

Commit 79c5aaa

Browse files
authored
WriteAsync must be awaited (#4491)
1 parent 1c09de8 commit 79c5aaa

File tree

3 files changed

+7
-10
lines changed

3 files changed

+7
-10
lines changed

dotnet/src/Microsoft.AutoGen/Agents/Services/Grpc/GrpcGateway.cs

+1-1
Original file line numberDiff line numberDiff line change
@@ -137,7 +137,7 @@ private async ValueTask AddSubscriptionAsync(GrpcWorkerConnection connection, Ad
137137
}
138138
_subscriptionsByAgentType[agentType] = request.Subscription;
139139
_subscriptionsByTopic.GetOrAdd(topic, _ => []).Add(agentType);
140-
await _subscriptions.Subscribe(topic, agentType);
140+
await _subscriptions.SubscribeAsync(topic, agentType);
141141
//var response = new AddSubscriptionResponse { RequestId = request.RequestId, Error = "", Success = true };
142142
Message response = new()
143143
{

dotnet/src/Microsoft.AutoGen/Agents/Services/Orleans/ISubscriptionsGrain.cs

+2-2
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
namespace Microsoft.AutoGen.Agents;
55
public interface ISubscriptionsGrain : IGrainWithIntegerKey
66
{
7-
ValueTask Subscribe(string agentType, string topic);
8-
ValueTask Unsubscribe(string agentType, string topic);
7+
ValueTask SubscribeAsync(string agentType, string topic);
8+
ValueTask UnsubscribeAsync(string agentType, string topic);
99
ValueTask<Dictionary<string, List<string>>> GetSubscriptions(string agentType);
1010
}

dotnet/src/Microsoft.AutoGen/Agents/Services/Orleans/SubscriptionsGrain.cs

+4-7
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ public ValueTask<Dictionary<string, List<string>>> GetSubscriptions(string? agen
1515
}
1616
return new ValueTask<Dictionary<string, List<string>>>(_subscriptions);
1717
}
18-
public ValueTask Subscribe(string agentType, string topic)
18+
public async ValueTask SubscribeAsync(string agentType, string topic)
1919
{
2020
if (!_subscriptions.TryGetValue(topic, out var subscriptions))
2121
{
@@ -27,11 +27,9 @@ public ValueTask Subscribe(string agentType, string topic)
2727
}
2828
_subscriptions[topic] = subscriptions;
2929
state.State.Subscriptions = _subscriptions;
30-
state.WriteStateAsync();
31-
32-
return ValueTask.CompletedTask;
30+
await state.WriteStateAsync().ConfigureAwait(false);
3331
}
34-
public ValueTask Unsubscribe(string agentType, string topic)
32+
public async ValueTask UnsubscribeAsync(string agentType, string topic)
3533
{
3634
if (!_subscriptions.TryGetValue(topic, out var subscriptions))
3735
{
@@ -43,8 +41,7 @@ public ValueTask Unsubscribe(string agentType, string topic)
4341
}
4442
_subscriptions[topic] = subscriptions;
4543
state.State.Subscriptions = _subscriptions;
46-
state.WriteStateAsync();
47-
return ValueTask.CompletedTask;
44+
await state.WriteStateAsync();
4845
}
4946
}
5047
public sealed class SubscriptionsState

0 commit comments

Comments
 (0)