Skip to content

Commit 732450d

Browse files
BeibinLiHk669
andauthored
Debug: Gemini client was not logged and causing runtime error (#2749)
* Debug: gemini client was not logged * Resolve docker issue in LMM test * Resolve comments --------- Co-authored-by: HRUSHIKESH DOKALA <[email protected]>
1 parent eedd947 commit 732450d

File tree

5 files changed

+13
-4
lines changed

5 files changed

+13
-4
lines changed

autogen/logger/file_logger.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
if TYPE_CHECKING:
1919
from autogen import Agent, ConversableAgent, OpenAIWrapper
20+
from autogen.oai.gemini import GeminiClient
2021

2122
logger = logging.getLogger(__name__)
2223

@@ -177,7 +178,9 @@ def log_new_wrapper(
177178
except Exception as e:
178179
self.logger.error(f"[file_logger] Failed to log event {e}")
179180

180-
def log_new_client(self, client: AzureOpenAI | OpenAI, wrapper: OpenAIWrapper, init_args: Dict[str, Any]) -> None:
181+
def log_new_client(
182+
self, client: AzureOpenAI | OpenAI | GeminiClient, wrapper: OpenAIWrapper, init_args: Dict[str, Any]
183+
) -> None:
181184
"""
182185
Log a new client instance.
183186
"""

autogen/logger/sqlite_logger.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@
1818

1919
if TYPE_CHECKING:
2020
from autogen import Agent, ConversableAgent, OpenAIWrapper
21+
from autogen.oai.gemini import GeminiClient
2122

2223
logger = logging.getLogger(__name__)
2324
lock = threading.Lock()
@@ -316,7 +317,7 @@ def log_new_wrapper(self, wrapper: OpenAIWrapper, init_args: Dict[str, Union[LLM
316317
self._run_query(query=query, args=args)
317318

318319
def log_new_client(
319-
self, client: Union[AzureOpenAI, OpenAI], wrapper: OpenAIWrapper, init_args: Dict[str, Any]
320+
self, client: Union[AzureOpenAI, OpenAI, GeminiClient], wrapper: OpenAIWrapper, init_args: Dict[str, Any]
320321
) -> None:
321322
if self.con is None:
322323
return

autogen/oai/client.py

+2-1
Original file line numberDiff line numberDiff line change
@@ -435,7 +435,8 @@ def _register_default_client(self, config: Dict[str, Any], openai_config: Dict[s
435435
elif api_type is not None and api_type.startswith("google"):
436436
if gemini_import_exception:
437437
raise ImportError("Please install `google-generativeai` to use Google OpenAI API.")
438-
self._clients.append(GeminiClient(**openai_config))
438+
client = GeminiClient(**openai_config)
439+
self._clients.append(client)
439440
else:
440441
client = OpenAI(**openai_config)
441442
self._clients.append(OpenAIClient(client))

autogen/runtime_logging.py

+4-1
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,7 @@
1313

1414
if TYPE_CHECKING:
1515
from autogen import Agent, ConversableAgent, OpenAIWrapper
16+
from autogen.oai.gemini import GeminiClient
1617

1718
logger = logging.getLogger(__name__)
1819

@@ -94,7 +95,9 @@ def log_new_wrapper(wrapper: OpenAIWrapper, init_args: Dict[str, Union[LLMConfig
9495
autogen_logger.log_new_wrapper(wrapper, init_args)
9596

9697

97-
def log_new_client(client: Union[AzureOpenAI, OpenAI], wrapper: OpenAIWrapper, init_args: Dict[str, Any]) -> None:
98+
def log_new_client(
99+
client: Union[AzureOpenAI, OpenAI, GeminiClient], wrapper: OpenAIWrapper, init_args: Dict[str, Any]
100+
) -> None:
98101
if autogen_logger is None:
99102
logger.error("[runtime logging] log_new_client: autogen logger is None")
100103
return

test/agentchat/contrib/test_lmm.py

+1
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ def test_group_chat_with_lmm():
122122
system_message="Ask both image explainer 1 and 2 for their description.",
123123
human_input_mode="NEVER", # Options: 'ALWAYS' or 'NEVER'
124124
max_consecutive_auto_reply=max_consecutive_auto_reply,
125+
code_execution_config=False,
125126
)
126127

127128
# Setting up the group chat

0 commit comments

Comments
 (0)