Fix GH bugs (#50)

* fix gh token lifetime and updating existing file in a branch

* create GH client transiently

* few more bug fixes

Author: kostapetan

samples/gh-flow/infra/app/gh-flow.bicep

@@ -103,7 +103,7 @@ module app '../core/host/container-app.bicep' = {
         value: location
       }
       {
-        name: 'AzureOptions__ManagedIdentity'
+        name: 'AZURE_CLIENT_ID'
         value: ghFlowIdentity.properties.clientId
       }
       {

samples/gh-flow/src/Microsoft.AI.DevTeam/Agents/Sandbox.cs

@@ -53,7 +53,7 @@ async Task IRemindable.ReceiveReminder(string reminderName, TickStatus status)
     {
         if (!_state.State.IsCompleted)
         {
-            var sandboxId =  $"sk-sandbox-{_state.State.Org}-{_state.State.Repo}-{_state.State.ParentIssueNumber}-{_state.State.IssueNumber}";
+            var sandboxId =  $"sk-sandbox-{_state.State.Org}-{_state.State.Repo}-{_state.State.ParentIssueNumber}-{_state.State.IssueNumber}".ToLower();
             if (await _azService.IsSandboxCompleted(sandboxId))
             {
                 await _azService.DeleteSandbox(sandboxId);

samples/gh-flow/src/Microsoft.AI.DevTeam/Program.cs

@@ -21,7 +21,8 @@
 builder.Services.AddTransient(CreateMemory);
 builder.Services.AddHttpClient();
 
-builder.Services.AddSingleton(s =>
+
+builder.Services.AddTransient(s =>
 {
     var ghOptions = s.GetService<IOptions<GithubOptions>>();
     var logger = s.GetService<ILogger<GithubAuthService>>();
@@ -30,11 +31,10 @@
     return client;
 });
 
-
 builder.Services.AddAzureClients(clientBuilder =>
 {
-    clientBuilder.UseCredential(new DefaultAzureCredential());
     clientBuilder.AddArmClient(default);
+    clientBuilder.UseCredential(new DefaultAzureCredential());
 });
 
 builder.Services.AddSingleton<GithubAuthService>();

samples/gh-flow/src/Microsoft.AI.DevTeam/Services/AzureService.cs

@@ -66,7 +66,7 @@ public async Task RunInSandbox(string org, string repo, long parentIssueNumber,
     {
         try
         {
-            var runId = $"sk-sandbox-{org}-{repo}-{parentIssueNumber}-{issueNumber}";
+            var runId = $"sk-sandbox-{org}-{repo}-{parentIssueNumber}-{issueNumber}".ToLower();
             var resourceGroupResourceId = ResourceGroupResource.CreateResourceIdentifier(_azSettings.SubscriptionId, _azSettings.ContainerInstancesResourceGroup);
             var resourceGroupResource = _client.GetResourceGroupResource(resourceGroupResourceId);
             var scriptPath = $"/azfiles/output/{org}-{repo}/{parentIssueNumber}/{issueNumber}/run.sh";

samples/gh-flow/src/Microsoft.AI.DevTeam/Services/GithubService.cs

@@ -51,9 +51,23 @@ public async Task CommitToBranch(string org, string repo, long parentNumber, lon
                             {
                                 var value = reader.ReadToEnd();
 
-                                await _ghClient.Repository.Content.CreateFile(
+                                 // Check if the file exists
+                                var existingFiles = await _ghClient.Repository.Content.GetAllContentsByRef(org, repo, filePath, branch);
+                                if (existingFiles.Any())
+                                {
+                                    var existingFile = existingFiles.First();
+                                    // If the file exists, update it
+                                    var updateChangeSet = await _ghClient.Repository.Content.UpdateFile(
                                         org, repo, filePath,
-                                        new CreateFileRequest($"Commit message", value, branch)); // TODO: add more meaningfull commit message
+                                        new UpdateFileRequest("Updated file via AI", value, existingFile.Sha, branch)); // TODO: add more meaningfull commit message
+                                }
+                                else
+                                {
+                                    // If the file doesn't exist, create it
+                                    var createChangeSet = await _ghClient.Repository.Content.CreateFile(
+                                        org, repo, filePath,
+                                        new CreateFileRequest("Created file via AI", value, branch)); // TODO: add more meaningfull commit message
+                                }
                             }
                         }
                         catch (Exception ex)

src/Microsoft.AI.Agents.Orleans/AiAgent.cs

@@ -44,6 +44,7 @@ public virtual async Task<string> CallFunction(string template, KernelArguments
         var function = _kernel.CreateFunctionFromPrompt(template, propmptSettings);
         var result = (await _kernel.InvokeAsync(function, arguments)).ToString();
         AddToHistory(result, ChatUserType.Agent);
+        await _state.WriteStateAsync();
         return result;
     }