Skip to content

Commit 06ba5d3

Browse files
authored
Rename ModelClient to ChatCompletionClient (#54)
1 parent ab420cc commit 06ba5d3

File tree

4 files changed

+13
-8
lines changed

4 files changed

+13
-8
lines changed

src/agnext/chat/agents/chat_completion_agent.py

+7-2
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,12 @@
1717
TypeRoutedAgent,
1818
message_handler,
1919
)
20-
from agnext.components.models import FunctionExecutionResult, FunctionExecutionResultMessage, ModelClient, SystemMessage
20+
from agnext.components.models import (
21+
ChatCompletionClient,
22+
FunctionExecutionResult,
23+
FunctionExecutionResultMessage,
24+
SystemMessage,
25+
)
2126
from agnext.components.tools import Tool
2227
from agnext.core import AgentRuntime, CancellationToken
2328

@@ -29,7 +34,7 @@ def __init__(
2934
description: str,
3035
runtime: AgentRuntime,
3136
system_messages: List[SystemMessage],
32-
model_client: ModelClient,
37+
model_client: ChatCompletionClient,
3338
tools: Sequence[Tool] = [],
3439
) -> None:
3540
super().__init__(name, description, runtime)

src/agnext/components/models/__init__.py

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
from ._model_client import ModelCapabilities, ModelClient
1+
from ._model_client import ChatCompletionClient, ModelCapabilities
22
from ._openai_client import (
33
AzureOpenAI,
44
OpenAI,
@@ -19,7 +19,7 @@
1919
"AzureOpenAI",
2020
"OpenAI",
2121
"ModelCapabilities",
22-
"ModelClient",
22+
"ChatCompletionClient",
2323
"SystemMessage",
2424
"UserMessage",
2525
"AssistantMessage",

src/agnext/components/models/_model_client.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ class ModelCapabilities(TypedDict, total=False):
2222

2323

2424
@runtime_checkable
25-
class ModelClient(Protocol):
25+
class ChatCompletionClient(Protocol):
2626
# Caching has to be handled internally as they can depend on the create args that were stored in the constructor
2727
async def create(
2828
self,

src/agnext/components/models/_openai_client.py

+3-3
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
)
3737
from ..tools import Tool
3838
from . import _model_info
39-
from ._model_client import ModelCapabilities, ModelClient
39+
from ._model_client import ChatCompletionClient, ModelCapabilities
4040
from ._types import (
4141
AssistantMessage,
4242
CreateResult,
@@ -214,7 +214,7 @@ def convert_tools(
214214
return result
215215

216216

217-
class BaseOpenAI(ModelClient):
217+
class BaseOpenAI(ChatCompletionClient):
218218
def __init__(
219219
self,
220220
client: Union[AsyncOpenAI, AsyncAzureOpenAI],
@@ -245,7 +245,7 @@ def __init__(
245245
self._actual_usage = RequestUsage(prompt_tokens=0, completion_tokens=0)
246246

247247
@classmethod
248-
def create_from_config(cls, config: Dict[str, Any]) -> ModelClient:
248+
def create_from_config(cls, config: Dict[str, Any]) -> ChatCompletionClient:
249249
return OpenAI(**config)
250250

251251
async def create(

0 commit comments

Comments
 (0)