Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can a list have children that are not listitem (or group) #3486

Closed
Anschur opened this issue Oct 19, 2020 · 6 comments
Closed

Can a list have children that are not listitem (or group) #3486

Anschur opened this issue Oct 19, 2020 · 6 comments
Labels
bug Something isn't working

Comments

@Anschur
Copy link

Anschur commented Oct 19, 2020

Hi!

If I have list (ul) and place a button directly inside it get an error that the list is not correctly structured:
https://dequeuniversity.com/rules/axe/4.0/list?application=msftAI

But if I have a structure where I use roles instead of semantic elements:
<div role="list">
<div role="listitem">...</div>
<div role="listitem">...</div>
<button>Click me</button>
</div>

Accessibility Insights is fine with it.
Is this allowed or is it a bug/missed case in Accessibility Insights?

@ghost ghost added the status: new This issue is new and requires triage by DRI. label Oct 19, 2020
@ghost ghost assigned karanbirsingh Oct 19, 2020
@DaveTryon DaveTryon assigned DaveTryon and unassigned karanbirsingh Oct 19, 2020
@DaveTryon DaveTryon added the status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. label Oct 19, 2020
@ghost
Copy link

ghost commented Oct 19, 2020

This issue requires additional investigation by the Accessibility Insights team. When the issue is ready to be triaged again, we will update the issue with the investigation result and add "status: ready for triage". Thank you for contributing to Accessibility Insights!

@ghost ghost removed the status: new This issue is new and requires triage by DRI. label Oct 19, 2020
@DaveTryon
Copy link
Contributor

Thanks, @Anschur! We're investigating this now and will update this issue once we have more information.

@DaveTryon
Copy link
Contributor

@Anschur, this appears to be a shortcoming in axe-core (the engine that we use for scanning). We've opened dequelabs/axe-core#2576 to report it and will pick up the fix once it's available.

@DaveTryon DaveTryon assigned ferBonnin and unassigned DaveTryon Oct 21, 2020
@DaveTryon DaveTryon added status: blocked This issue is blocked. and removed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. labels Oct 21, 2020
@ferBonnin ferBonnin added the bug Something isn't working label Oct 29, 2020
@ferBonnin
Copy link
Contributor

@iamrafan could you please update?

@iamrafan
Copy link

@ferBonnin we have been told allowing this use case is not required by ARIA and issue w3c/aria#1033 has been filed to get more clarity about the guidance/definition for "required owned element"

@iamrafan
Copy link

iamrafan commented Jan 4, 2021

@Anschur The description of 'Required owned elements' and 'Owned elements' in ARIA is somewhat problematic. The ARIA working group is working to clarify the definitions to help users interpret the guidance better (w3c/aria#1033).

Going by the discussion in the (w3c/aria#1033) thread, it looks like the example you mentioned need not be failed and hence this is not a missed case or a false negative case. I am closing this issue, please feel free to get back to us if you have any further questions.

@iamrafan iamrafan closed this as completed Jan 4, 2021
@iamrafan iamrafan removed the status: blocked This issue is blocked. label Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants