Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement better commenting in AppInstance.cpp's GetCommandLine. #903

Closed
aeloros opened this issue Jun 2, 2021 · 0 comments
Closed

Implement better commenting in AppInstance.cpp's GetCommandLine. #903

aeloros opened this issue Jun 2, 2021 · 0 comments
Assignees

Comments

@aeloros
Copy link
Contributor

aeloros commented Jun 2, 2021

Probably should have a comment somewhere saying what the command line we're trying to parse actually is. I'm guessing

// The payload begins with four dashes and a contract name (no spaces allowed),
// optionally followed by a colon and data (no spaces allowed).
// The payload ends at the next space or end of string.
//
// Example:
//  contoso.exe blah ----somecontract:eW91IGFyZSBjdXJpb3Vz blah
//                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
//
// If there is no data, then an empty string is returned as the data.
//
// Returns { contract_name, data } if a payload is found.
// Returns { L"", L"" } if no payload is found.

Originally posted by @oldnewthing in #823 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants