-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
About the video resolution. #48
Comments
Look for ControlScript.cs - it should be at a location similar to this: |
@jamescadd Thank you ! But now I am working on the PeerConnectionClient.WebRtc.UnityXaml.sln. Is there anyway to downscale the resolution? |
@jamescadd Sorry maybe I need to explain it clearly, I want to downscale the video stream sending from holoLens to PC. Thanks a lot. |
No problem, here's a link to the resolution setting. This is already defaulted to 895x504, do you have reason to believe that's not happening? If you run the code in VS with the debugger attached (debug build) you should be able to go through the logs to find the chosen resolution. Let me know if that helps. |
@jamescadd Thanks for your reply. But I want to make this default resolution smaller, this default (also https://blog.mozilla.org/webrtc/fiddle-week-downscale-video-peerconnection/. |
Ok that makes sense. We added scaleResolutionDownBy in M66 though it hasn't be tested (if there is a bug, we'll fix it). The problem is M66 was a large move to C++/WinRT and new Unity tooling, and while it's tested and working on Desktop I haven't been able to test on HoloLens yet. You need Unity 2018.2.13f1 and the C++/WinRT VS plugin. Also the XAML solution is no longer present so the build steps require using Unity editor too. https://github.com/ortclib/ortclib-sdk/tree/Mosa/20180911-peercc-unity-upgrade Steps:
|
@jamescadd Thank you so much! I will try it. |
@jamescadd Hi, When I open the the ortlib-sdk I got these errors. Could you give me more details about how to build up the application? Many thanks!! 嚴重性 程式碼 說明 專案 檔案 行 隱藏項目狀態 C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\CMake\bin\cmake.exe -G "Ninja" -DCMAKE_INSTALL_PREFIX:PATH="C:\Users\astri\CMakeBuilds\55e55ed3-ce29-0438-b45b-8e9cb6993a71\install\x64-Debug (__)" -DCMAKE_CXX_COMPILER="C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.15.26726/bin/HostX64/x64/cl.exe" -DCMAKE_C_COMPILER="C:/Program Files (x86)/Microsoft Visual Studio/2017/Community/VC/Tools/MSVC/14.15.26726/bin/HostX64/x64/cl.exe" -DCMAKE_BUILD_TYPE="Debug" -DCMAKE_MAKE_PROGRAM="C:\PROGRAM FILES (X86)\MICROSOFT VISUAL STUDIO\2017\COMMUNITY\COMMON7\IDE\COMMONEXTENSIONS\MICROSOFT\CMAKE\Ninja\ninja.exe" "C:\ortclib-sdk\webrtc\xplatform\boringssl" 傳回結束代碼: 1 |
My mistake - the above link is actually on M62, the M66 Unity version is still in progress. I'll update you when it's ready or feel free to ping me over email at jacadd on the Microsoft domain. I would expect this to be ready within a week. If you still want to test that branch it could be that the error is due to not cloning recursively. Could you double check that? Also did the prepare script run without issue? If you could run "bin\prepare.bat -logLevel 4" and send the output we may be able to diagnose the error. |
@jamescadd Thank you. I clone recursively, and then change to the Mosa/20180911-peercc-unity-upgrade branch. Run "bin\prepare.bat -logLevel 4" but everything is fine. |
After some research it does not appear that scaleResolutionDownBy is implemented yet in the WebRTC codebase (we means we do not yet have the feature either): https://chromium.googlesource.com/external/webrtc/+/master/pc/rtpsender.cc#39 I can still help you get the full build working however. Good to hear that prepare is working properly, but if you have the log it would still be nice to post so we can double check. If you could additionally post the full VS output for a build we can look as well. Apologies that this has taken so much time to get working. |
@jamescadd Hi, understand and thanks for your help. This is the debug log when I open the ortclib in VS 2017. |
Looking at the log it seems like the errors are related to Go and Gmock. Could you post the results of "bin\prepare.bat -logLevel 4" so I can take a look? Perhaps some tooling is not being downloaded correctly. |
I found that the lowest resolution on HoloLens is 895*504.
Could anyone give me some advice on how to downscale this resolution?
Many thanks!
The text was updated successfully, but these errors were encountered: