Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incompatible between ES6-promise thenable and recent PromiseLike change in lib.d.ts #9481

Closed
yuit opened this issue Jul 1, 2016 · 3 comments
Closed

Incompatible between ES6-promise thenable and recent PromiseLike change in lib.d.ts #9481

yuit opened this issue Jul 1, 2016 · 3 comments
Assignees
@yuit
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Milestone
TypeScript 2.0

Comments

@yuit
Copy link
Contributor

yuit commented Jul 1, 2016

Our Angular2 code-base of RWC uses es6-promise for defining Promise interface as well as PromiseLike definition from our lib.d.ts. With our recent change, Thenable and PromiseLike is no longer compatible.
@yuit yuit added this to the TypeScript 2.0 milestone Jul 1, 2016
@yuit yuit added the Bug A bug in TypeScript label Jul 1, 2016
@mhegazy
Copy link
Contributor

mhegazy commented Jul 1, 2016

@rbuckton can you see if reverting the changes to PromiseLike would do?

@rbuckton
Copy link
Member

rbuckton commented Jul 2, 2016

I reviewed this with @yuit, reverting the change to PromiseLike fixes the issue, and does not impact the improved typing for Promise.

@mhegazy
Copy link
Contributor

mhegazy commented Jul 2, 2016 •
edited
Loading

Fixed by #9484

@mhegazy mhegazy assigned yuit and unassigned rbuckton Jul 2, 2016
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Jul 5, 2016
@mhegazy mhegazy closed this as completed Jul 5, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@yuit yuit

Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Milestone
TypeScript 2.0
Development

No branches or pull requests
3 participants
@yuit @rbuckton @mhegazy