Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing RegExp#unicodeSets #57055

Closed
Josh-Cena opened this issue Jan 14, 2024 · 4 comments · Fixed by #57111
Closed

Missing RegExp#unicodeSets #57055

Josh-Cena opened this issue Jan 14, 2024 · 4 comments · Fixed by #57111
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Milestone

Comments

@Josh-Cena
Copy link
Contributor

Josh-Cena commented Jan 14, 2024

⚙ Compilation target

ESNext

⚙ Library

ESNext

Missing / Incorrect Definition

Missing RegExp#unicodeSets property

Sample Code

/[a]/v.unicodeSets

Documentation Link

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/RegExp/unicodeSets

@RyanCavanaugh RyanCavanaugh added Bug A bug in TypeScript Help Wanted You can do this Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript labels Jan 16, 2024
@RyanCavanaugh RyanCavanaugh added this to the Backlog milestone Jan 16, 2024
@fatcerberus
Copy link

tc39: uses meaningless letter v because "it's just u but better"
also tc39: calls corresponding property unicodeSets implying it's an additional feature rather than just an enhanced mode

@Josh-Cena
Copy link
Contributor Author

Josh-Cena commented Jan 16, 2024

implying it's an additional feature rather than just an enhanced mode

There are incompatibilities. It's not a strict superset of any existing feature. If it's just an "enhanced mode", a new flag won't be necessary. You can read the linked documentation to see what changed.

@fatcerberus
Copy link

fatcerberus commented Jan 16, 2024

Yeah, I get that, but unicodeSets implies it's supplemental, i.e. that v is something you specify in addition to u. At least the weird "we called it v because it's u+1" reasoning adequately explains why they're mutually exclusive. The naming scheme here is just weird.

@Josh-Cena
Copy link
Contributor Author

There were discussions about whether v should still make unicode be true but it was eventually decided otherwise. Anyway that's pretty tangential

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug A bug in TypeScript Domain: lib.d.ts The issue relates to the different libraries shipped with TypeScript Help Wanted You can do this
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants