-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Method snippet follow-up #46568
Comments
Two more things:
|
I have found I don't miss this when I have completions preview turned on. Also, at least in VSCode there is a truncated preview of the insert text next to the name of the completion, but I don't know how other editors display this. |
100%. I think this is why I didn't notice this in my initial review of #46370. But it's still not the default.
This is actually the detail text that we’ve always generated in completion details. It does help, but the fact that it's the same as it's always been for completions that just insert the name (and the same as it will continue to be if a user disables the member completion snippets) makes me feel like maybe it should be more obvious that we're going to insert additional text... but this is definitely worth gathering feedback on; I don't feel like I have the perfect answer. |
List of follow-up items from #46370 that were easier to put in separate PR(s). I tried to sort these by priority order, and the last couple I don’t think we’ll schedule at all for now. We can close this issue when we’ve done everything worth scheduling for a milestone.
Add$0
tabstop at the same location as$1
tabstop (in method body)Make auto-imported types work
getCompletionsAtPosition
would require a protocol change and corresponding update in typescript-language-features. There are some workarounds we could implement by sending the back as part ofgetCompletionEntryDetails
instead, which would work with no VS Code update. Maybe we should discuss this at next week's editor sync. My feeling is this qualifies as a bug fix, but if we need a VS Code update, we’ll need to coordinate with @mjbvz, and we’re also nearing the end of our own release cycle, so I’m not sure what the best strategy is here.From @amcasey at Add method signature completions #46370 (comment):
public
must precedeabstract
.From @amcasey at Add method signature completions #46370 (comment):
Improve
addMissingMember
codefix’s generated implementation signature for overloads (currently all parameters areunknown
(as of feat(47281): Implementing an interface suggests any as type #47308))The text was updated successfully, but these errors were encountered: