Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance regression in #33473 #36565

Open
amcasey opened this issue Feb 1, 2020 · 1 comment
Open

Performance regression in #33473 #36565

amcasey opened this issue Feb 1, 2020 · 1 comment
Assignees
@weswigham
Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status. Rescheduled This issue was previously scheduled to an earlier milestone
Milestone
TypeScript 5.7.0

Comments

@amcasey
Copy link
Member

amcasey commented Feb 1, 2020 •
edited
Loading

The extra work done in #33473 is valuable, but maybe it doesn't need to be so expensive. In this particular case, there don't seem to be any errors (though there is one @ts-ignore).

Setup:

  1. Clone https://github.com/amcasey/material-ui.git
  2. Check out Benchmark
  3. yarn to restore packages
  4. yarn typescript to prebuild and run some TS tests

Repro

  1. tsc -p docs

On a random Mac Mini:

  • 10-run avg on 6c2ae12: 33,010ms
  • 10-run avg on 26caa37: 33,494ms (1% slower)

Note: to build old TS commits, you probably need to change const { default: chalk } to const chalk in scripts/build/utils.js.
@amcasey amcasey added Needs Investigation This issue needs a team member to investigate its status. Domain: Performance Reports of unusually slow behavior labels Feb 1, 2020
@amcasey
Copy link
Member Author

amcasey commented Feb 1, 2020

FYI @weswigham

@amcasey amcasey mentioned this issue Feb 3, 2020
Closed
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 4.6.0 milestone Nov 3, 2021
@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@weswigham weswigham

Labels
Domain: Performance Reports of unusually slow behavior Needs Investigation This issue needs a team member to investigate its status. Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Milestone
TypeScript 5.7.0
Development

No branches or pull requests
4 participants
@DanielRosenwasser @weswigham @RyanCavanaugh @amcasey