Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine Perf Impact of 0-Span Refactoring Requests #34784

Closed
DanielRosenwasser opened this issue Oct 28, 2019 · 4 comments
Closed

Determine Perf Impact of 0-Span Refactoring Requests #34784

DanielRosenwasser opened this issue Oct 28, 2019 · 4 comments
Assignees
Labels
Domain: Performance Reports of unusually slow behavior Domain: Refactorings e.g. extract to constant or function, rename symbol Experimentation Needed Someone needs to try this out to see what happens Rescheduled This issue was previously scheduled to an earlier milestone

Comments

@DanielRosenwasser
Copy link
Member

In some editors, every cursor movement is followed by a request for possible refactorings. It's possible that these requests are causing delays in other editor operations. We should see whether this is the case, and if it is, understand whether this would impact long-term discoverability of our refactorings.

@DanielRosenwasser DanielRosenwasser added Domain: Refactorings e.g. extract to constant or function, rename symbol Domain: Performance Reports of unusually slow behavior Experimentation Needed Someone needs to try this out to see what happens labels Oct 28, 2019
@DanielRosenwasser DanielRosenwasser added this to the TypeScript 3.8.0 milestone Oct 28, 2019
@amcasey
Copy link
Member

amcasey commented Dec 6, 2019

The change has been implemented in a VS-side (internal) PR, but has not been merged because additional telemetry is required before we can A/B test it appropriately.

@amcasey
Copy link
Member

amcasey commented Jan 25, 2020

The telemetry changes are in-flight, so I think 3.9 is a plausible timeframe for this change (though nothing will actually change in this codebase).

@RyanCavanaugh RyanCavanaugh added the Rescheduled This issue was previously scheduled to an earlier milestone label May 20, 2020
@jessetrinity
Copy link
Contributor

#38378 allows us to explicitly request refactors for empty spans.

@amcasey
Copy link
Member

amcasey commented Aug 26, 2020

We ended up just speculatively making the change - precise measurement was impractically expensive.

@amcasey amcasey closed this as completed Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Performance Reports of unusually slow behavior Domain: Refactorings e.g. extract to constant or function, rename symbol Experimentation Needed Someone needs to try this out to see what happens Rescheduled This issue was previously scheduled to an earlier milestone
Projects
None yet
Development

No branches or pull requests

4 participants