Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update systemjs export emit to support new bulk export variation #3346

Closed
mhegazy opened this issue Jun 2, 2015 · 6 comments
Closed

Update systemjs export emit to support new bulk export variation #3346

mhegazy opened this issue Jun 2, 2015 · 6 comments
Labels
Breaking Change Would introduce errors in existing code Bug A bug in TypeScript

Comments

@mhegazy
Copy link
Contributor

mhegazy commented Jun 2, 2015

see ModuleLoader/es-module-loader#386 for more details about the fix.

@mhegazy mhegazy added the Bug A bug in TypeScript label Jun 2, 2015
@mhegazy
Copy link
Contributor Author

mhegazy commented Jun 2, 2015

@vladima We need to decide if this is a 1.5.2 issue or a 1.6 issue.

@vladima
Copy link
Contributor

vladima commented Jun 2, 2015

Given that current estimate for patch that will include bulk export support in es6 module loader is somewhere after forthcoming release I'd say that having this item fixed in 1.6 should be ok. I've asked @guybedford for more accurate timings, we can always reconsider this decision based on his answer

@vladima vladima added this to the TypeScript 1.6 milestone Jun 2, 2015
@mhegazy mhegazy added the Breaking Change Would introduce errors in existing code label Jul 21, 2015
@mhegazy
Copy link
Contributor Author

mhegazy commented Jul 21, 2015

Users will need to update to latest System.js/JSPM

@guybedford
Copy link
Contributor

TypeScript was only supported in SystemJS 0.17, which had the bulk export handling in place, so this shouldn't be breaking for TypeScript users of SystemJS.

@mhegazy
Copy link
Contributor Author

mhegazy commented Jul 22, 2015

I believe TypeScript support was added in release v0.17.0, where as the bulk export was added in release v0.17.1. @guybedford would it be safe to assume no one is using 0.17.0?

@guybedford
Copy link
Contributor

Yes there was a ~10 day release window where 0.17.0 was the primary release for TypeScript testing. Because it's a patch upgrade, and the TypeScript support was clearly indicated as a new in-progress feature, I see no issue with including this in TypeScript and allowing the break for that tiny segment, who can simply do a patch update. Strictly it is a breaking change though for this segment, so can certainly be worth documenting according to what fits into your process there.

@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Breaking Change Would introduce errors in existing code Bug A bug in TypeScript
Projects
None yet
Development

No branches or pull requests

3 participants