Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion diagnostics show in untyped JS code when regular diagnostics don't #27852

Open
ghost opened this issue Oct 11, 2018 · 0 comments
Open
Labels
Domain: Error Messages The issue relates to error messaging Domain: TSServer Issues related to the TSServer In Discussion Not yet reached consensus Suggestion An idea for TypeScript

Comments

@ghost
Copy link

ghost commented Oct 11, 2018

TypeScript Version: 3.2.0-dev.20181011

Code

"".toUperKase();
const b = require("./b");

Expected behavior:

If we're not showing regular diagnostics, we should probably not show any suggestions either.

Actual behavior:

"".toUperKase() is fine. require is a real problem that we need to let the user know about right away!

uperkase

@ghost ghost added the Suggestion An idea for TypeScript label Oct 11, 2018
@weswigham weswigham added Domain: Error Messages The issue relates to error messaging Domain: TSServer Issues related to the TSServer In Discussion Not yet reached consensus labels Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Domain: Error Messages The issue relates to error messaging Domain: TSServer Issues related to the TSServer In Discussion Not yet reached consensus Suggestion An idea for TypeScript
Projects
None yet
Development

No branches or pull requests

1 participant