Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please remove non-ES6 types from lib.d.ts #2697

Closed
Arnavion opened this issue Apr 9, 2015 · 5 comments
Closed

Please remove non-ES6 types from lib.d.ts #2697

Arnavion opened this issue Apr 9, 2015 · 5 comments
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue

Comments

@Arnavion
Copy link
Contributor

Arnavion commented Apr 9, 2015

The "IE11 ECMAScript Extensions" contains ES6 collections, which allows code aimed at ES5 runtimes to mistakenly use them and fail at runtime.

For backward compatibility, perhaps make a new lib.es5.d.ts that doesn't have these sections. That will also require a way to override the default lib independent of specifying the target.

@mhegazy mhegazy added the Bug A bug in TypeScript label Apr 9, 2015
@mhegazy
Copy link
Contributor

mhegazy commented Apr 9, 2015

Should be removed in PR #2645

@Arnavion
Copy link
Contributor Author

Arnavion commented Apr 9, 2015

Currently that PR doesn't touch extensions.d.ts, which is where the non-ES5 extensions come from. https://github.com/Microsoft/TypeScript/blob/b1c93d3/Jakefile#L162

@mhegazy
Copy link
Contributor

mhegazy commented Apr 9, 2015

I left a comment(#2645 (comment)) for @zhengbli to remove the extensions. the reason we had them is that dom typings depended on them. with the latest change i believe this is not the case any more.

@mhegazy
Copy link
Contributor

mhegazy commented Apr 9, 2015

also we have another issue tracking this #2636

@Arnavion
Copy link
Contributor Author

Fixed by #2739

@mhegazy mhegazy added this to the TypeScript 1.5 milestone Apr 18, 2015
@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Apr 18, 2015
@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug A bug in TypeScript Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants