Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jake runtests-browser broken #22905

Closed
ghost opened this issue Mar 27, 2018 · 1 comment
Closed

jake runtests-browser broken #22905

ghost opened this issue Mar 27, 2018 · 1 comment
Assignees
Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure

Comments

@ghost
Copy link

ghost commented Mar 27, 2018

TypeScript Version: master

Code

> jake runtests-browser b=chrome t=completion
Saving sourcemaps for C:\Users\anhans\work\TypeScript\built\local\bundle.js
Fixing sourcemaps for C:\Users\anhans\work\TypeScript\built\local\bundle.js
Error: ENOENT: no such file or directory, open 'C:\Users\anhans\work\TypeScript\src\services\(.+)$\gm;'

I checked and this worked in the commit before #22658. @weswigham

@ghost ghost added the Infrastructure Issue relates to TypeScript team infrastructure label Mar 27, 2018
@weswigham weswigham self-assigned this Mar 29, 2018
@weswigham
Copy link
Member

Heh. I've looked into it. It's alllll because of this line:

image

Sorcery's sourcemappingURL-finding regex is significantly more permissive (worse?) than our own and, in fact, picks up our sourceMappingURL regexp as a sourceMappingURL comment, and then tries to lookup the file (.+$)/gm.

#23006 is now open with a fix

@mhegazy mhegazy added the Fixed A PR has been merged for this issue label Mar 30, 2018
@mhegazy mhegazy added this to the TypeScript 2.9 milestone Mar 30, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Fixed A PR has been merged for this issue Infrastructure Issue relates to TypeScript team infrastructure
Projects
None yet
Development

No branches or pull requests

2 participants