Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Duplicate auto import suggestions returned for @angular/material #19922

Closed
mjbvz opened this issue Nov 10, 2017 · 6 comments
Closed

Duplicate auto import suggestions returned for @angular/material #19922

mjbvz opened this issue Nov 10, 2017 · 6 comments
Labels
Duplicate An existing issue was already created Fixed A PR has been merged for this issue

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 10, 2017

From microsoft/vscode#37930

TypeScript Version: 2.6.1

Reop
In a new folder:

  1. run $ npm init -y and npm install @angular/material
  2. Create a empty jsconfig.json
  3. In a new js file, try triggering suggestions

Bug:
Notice that there are multiple, duplicate entries for items such as MatAccordion:

screen shot 2017-11-10 at 11 51 42 am

I confirmed that these duplicate entries are being returned by the TS server
@mjbvz mjbvz added the VS Code Tracked There is a VS Code equivalent to this issue label Nov 10, 2017
@mjbvz
Copy link
Contributor Author

mjbvz commented Nov 10, 2017

I suspect this may have something to do with how @angular/material re-exports symbols

@mjbvz mjbvz mentioned this issue Nov 10, 2017
Closed
@mhegazy
Copy link
Contributor

mhegazy commented Nov 10, 2017

seems like a duplicate of #19694 and #19889

@mhegazy mhegazy added Duplicate An existing issue was already created and removed VS Code Tracked There is a VS Code equivalent to this issue labels Nov 10, 2017
This was referenced Nov 10, 2017
Closed
Closed
Closed
@ghost ghost mentioned this issue Nov 15, 2017
Merged
@ghost ghost added the Fixed A PR has been merged for this issue label Nov 16, 2017
@mhegazy
Copy link
Contributor

mhegazy commented Nov 17, 2017

Fixed by #20049

@mjbvz
Copy link
Contributor Author

mjbvz commented Dec 8, 2017

Confirmed this seems to be fixed in TS@next:

screen shot 2017-12-08 at 3 36 47 pm

@mjbvz mjbvz closed this as completed Dec 8, 2017
@jtsom
Copy link

jtsom commented Dec 12, 2017

Problem still exists, and worse, in 2.7dev:

ts270dev

@mhegazy
Copy link
Contributor

mhegazy commented Jan 11, 2018

@jtsom mind logging a new issue and giving us more context.

@microsoft microsoft locked and limited conversation to collaborators Jul 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Duplicate An existing issue was already created Fixed A PR has been merged for this issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jtsom @mhegazy @mjbvz