Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Template string aren't recognized by classifier #1884

Closed
jrieken opened this issue Feb 2, 2015 · 2 comments
Closed

Template string aren't recognized by classifier #1884

jrieken opened this issue Feb 2, 2015 · 2 comments
Labels
Duplicate An existing issue was already created Fixed A PR has been merged for this issue

Comments

@jrieken
Copy link
Member

jrieken commented Feb 2, 2015

https://github.com/Microsoft/TypeScript/blob/ab9ce1e9e6636ec6a2aa4f01458525f249c4edf5/src/services/services.ts#L1172

I would expect them to get a special treatment. For instance

`Hello ${name}`

could have tokens like: string(Hello), punct(${), identifier(name), punct(}), string()

@DanielRosenwasser
Copy link
Member

Duplicate of #1698, #1716, and #1477. In #1477 I give an explanation of the technical difficulties associated with highlighting a context free construct template strings, however, I decided that it was an inappropriate experience so now we just do our best to propagate template state across lines. #1744 has a fix.

@DanielRosenwasser DanielRosenwasser added the Duplicate An existing issue was already created label Feb 2, 2015
@DanielRosenwasser DanielRosenwasser added the Fixed A PR has been merged for this issue label Feb 13, 2015
@DanielRosenwasser
Copy link
Member

A fix is now in master through #2026.

@microsoft microsoft locked and limited conversation to collaborators Jun 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created Fixed A PR has been merged for this issue
Projects
None yet
Development

No branches or pull requests

3 participants