Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSDoc removed from '.d.ts' when removeComments: true #11129

Closed
TheColorRed opened this issue Sep 24, 2016 · 1 comment
Closed

JSDoc removed from '.d.ts' when removeComments: true #11129

TheColorRed opened this issue Sep 24, 2016 · 1 comment
Labels
Duplicate An existing issue was already created

Comments

@TheColorRed
Copy link

TypeScript Version: 2.0.3

.vscode/settings.json

{
    "typescript.tsdk": "./node_modules/typescript/lib"
}

./tsconfig.json

{
    "compilerOptions": {
        "target": "es6",
        "module": "system",
        "removeComments": true,
        "out": "./root/dist/javascript.js",
        "watch": true,
        "declaration": true
    }
}

Expected behavior:

When declaration: true and removeComments: true, I would expect comments to be removed from the javascript file(s), and leave the JSDoc in the .d.ts file(s).

Actual behavior:

All comments are removed from all files.

When declaration: true and removeComments: false comments don't get removed from the javascript file(s) but they do get removed from the .d.ts file(s) unless it is JSDoc.

@mhegazy
Copy link
Contributor

mhegazy commented Nov 9, 2016

looks like the same issue as #11774

@mhegazy mhegazy added the Duplicate An existing issue was already created label Nov 9, 2016
@mhegazy mhegazy closed this as completed Dec 15, 2016
@microsoft microsoft locked and limited conversation to collaborators Jun 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Duplicate An existing issue was already created
Projects
None yet
Development

No branches or pull requests

2 participants