Skip to content

Commit 2eb12ed

Browse files
CopilotDanielRosenwasser
Copilot
and
DanielRosenwasser
committed
Fix libReplacement condition and update baselines
Changed libReplacement check from `=== false` to truthy check to properly handle the new default behavior. Updated test baselines to reflect the change. Co-authored-by: DanielRosenwasser <[email protected]>
1 parent d18d9b2 commit 2eb12ed

20 files changed

+1165
-1534
lines changed

‎src/compiler/program.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3867,7 +3867,7 @@ export function createProgram(_rootNamesOrOptions: readonly string[] | CreatePro
38673867
const existing = resolvedLibProcessing?.get(libFileName);
38683868
if (existing) return existing;
38693869

3870-
if (options.libReplacement === false) {
3870+
if (options.libReplacement) {
38713871
const result: LibResolution = {
38723872
resolution: {
38733873
resolvedModule: undefined,

‎tests/baselines/reference/bundlerCommonJS.trace.json‎

Lines changed: 73 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,5 +38,77 @@
3838
"Entering conditional exports.",
3939
"Saw non-matching condition 'require'.",
4040
"Exiting conditional exports.",
41-
"======== Module name 'pkg' was not resolved. ========"
41+
"======== Module name 'pkg' was not resolved. ========",
42+
"======== Resolving module '@typescript/lib-es5' from '/.src/__lib_node_modules_lookup_lib.es5.d.ts__.ts'. ========",
43+
"Explicitly specified module resolution kind: 'Node10'.",
44+
"Loading module '@typescript/lib-es5' from 'node_modules' folder, target file types: TypeScript, Declaration.",
45+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
46+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
47+
"Scoped package detected, looking in 'typescript__lib-es5'",
48+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
49+
"Scoped package detected, looking in 'typescript__lib-es5'",
50+
"Loading module '@typescript/lib-es5' from 'node_modules' folder, target file types: JavaScript.",
51+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
52+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
53+
"======== Module name '@typescript/lib-es5' was not resolved. ========",
54+
"======== Resolving module '@typescript/lib-decorators' from '/.src/__lib_node_modules_lookup_lib.decorators.d.ts__.ts'. ========",
55+
"Explicitly specified module resolution kind: 'Node10'.",
56+
"Loading module '@typescript/lib-decorators' from 'node_modules' folder, target file types: TypeScript, Declaration.",
57+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
58+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
59+
"Scoped package detected, looking in 'typescript__lib-decorators'",
60+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
61+
"Scoped package detected, looking in 'typescript__lib-decorators'",
62+
"Loading module '@typescript/lib-decorators' from 'node_modules' folder, target file types: JavaScript.",
63+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
64+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
65+
"======== Module name '@typescript/lib-decorators' was not resolved. ========",
66+
"======== Resolving module '@typescript/lib-decorators/legacy' from '/.src/__lib_node_modules_lookup_lib.decorators.legacy.d.ts__.ts'. ========",
67+
"Explicitly specified module resolution kind: 'Node10'.",
68+
"Loading module '@typescript/lib-decorators/legacy' from 'node_modules' folder, target file types: TypeScript, Declaration.",
69+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
70+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
71+
"Scoped package detected, looking in 'typescript__lib-decorators/legacy'",
72+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
73+
"Scoped package detected, looking in 'typescript__lib-decorators/legacy'",
74+
"Loading module '@typescript/lib-decorators/legacy' from 'node_modules' folder, target file types: JavaScript.",
75+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
76+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
77+
"======== Module name '@typescript/lib-decorators/legacy' was not resolved. ========",
78+
"======== Resolving module '@typescript/lib-dom' from '/.src/__lib_node_modules_lookup_lib.dom.d.ts__.ts'. ========",
79+
"Explicitly specified module resolution kind: 'Node10'.",
80+
"Loading module '@typescript/lib-dom' from 'node_modules' folder, target file types: TypeScript, Declaration.",
81+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
82+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
83+
"Scoped package detected, looking in 'typescript__lib-dom'",
84+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
85+
"Scoped package detected, looking in 'typescript__lib-dom'",
86+
"Loading module '@typescript/lib-dom' from 'node_modules' folder, target file types: JavaScript.",
87+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
88+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
89+
"======== Module name '@typescript/lib-dom' was not resolved. ========",
90+
"======== Resolving module '@typescript/lib-webworker/importscripts' from '/.src/__lib_node_modules_lookup_lib.webworker.importscripts.d.ts__.ts'. ========",
91+
"Explicitly specified module resolution kind: 'Node10'.",
92+
"Loading module '@typescript/lib-webworker/importscripts' from 'node_modules' folder, target file types: TypeScript, Declaration.",
93+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
94+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
95+
"Scoped package detected, looking in 'typescript__lib-webworker/importscripts'",
96+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
97+
"Scoped package detected, looking in 'typescript__lib-webworker/importscripts'",
98+
"Loading module '@typescript/lib-webworker/importscripts' from 'node_modules' folder, target file types: JavaScript.",
99+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
100+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
101+
"======== Module name '@typescript/lib-webworker/importscripts' was not resolved. ========",
102+
"======== Resolving module '@typescript/lib-scripthost' from '/.src/__lib_node_modules_lookup_lib.scripthost.d.ts__.ts'. ========",
103+
"Explicitly specified module resolution kind: 'Node10'.",
104+
"Loading module '@typescript/lib-scripthost' from 'node_modules' folder, target file types: TypeScript, Declaration.",
105+
"Searching all ancestor node_modules directories for preferred extensions: TypeScript, Declaration.",
106+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
107+
"Scoped package detected, looking in 'typescript__lib-scripthost'",
108+
"Directory '/node_modules/@types' does not exist, skipping all lookups in it.",
109+
"Scoped package detected, looking in 'typescript__lib-scripthost'",
110+
"Loading module '@typescript/lib-scripthost' from 'node_modules' folder, target file types: JavaScript.",
111+
"Searching all ancestor node_modules directories for fallback extensions: JavaScript.",
112+
"Directory '/.src/node_modules' does not exist, skipping all lookups in it.",
113+
"======== Module name '@typescript/lib-scripthost' was not resolved. ========"
42114
]

0 commit comments

Comments
 (0)