Skip to content

vector_algorithms.cpp: Fix zeroupper guard for is_sorted_until vectorization #5540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

vector_algorithms.cpp: Fix zeroupper guard for is_sorted_until vectorization #5540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions stl/src/vector_algorithms.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -601,6 +601,7 @@ namespace {

#ifndef _M_ARM64EC
struct _Traits_sse_base {
using _Guard = char;
static constexpr bool _Vectorized = true;
static constexpr size_t _Vec_size = 16;
static constexpr size_t _Vec_mask = 0xF;
Expand All @@ -626,6 +627,7 @@ namespace {
};

struct _Traits_avx_base {
using _Guard = _Zeroupper_on_exit;
static constexpr bool _Vectorized = true;
static constexpr size_t _Vec_size = 32;
static constexpr size_t _Vec_mask = 0x1F;
Expand Down Expand Up @@ -2409,6 +2411,8 @@ namespace {
#ifdef _M_ARM64EC
static_assert(false, "No vectorization for _M_ARM64EC yet");
#else // ^^^ defined(_M_ARM64EC) / !defined(_M_ARM64EC) vvv
[[maybe_unused]] typename _Traits::_Guard _Guard; // TRANSITION, DevCom-10331414

constexpr bool _Sign_cor = static_cast<_Ty>(-1) > _Ty{0};

const size_t _Total_size_bytes = _Byte_length(_First, _Last);
Expand Down Expand Up @@ -2470,8 +2474,6 @@ namespace {
_Advance_bytes(_First, _Tail_byte_size);
}
}

_Traits::_Exit_vectorized(); // TRANSITION, DevCom-10331414
#endif // ^^^ !defined(_M_ARM64EC) ^^^
}

Expand Down