Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

P3136R1 Retiring Niebloids #5138

Closed
StephanTLavavej opened this issue Nov 25, 2024 · 1 comment · Fixed by #5191
Closed

P3136R1 Retiring Niebloids #5138

StephanTLavavej opened this issue Nov 25, 2024 · 1 comment · Fixed by #5191
Labels
cxx26 C++26 feature fixed Something works now, yay! good first issue Good for newcomers ranges C++20/23 ranges

Comments

@StephanTLavavej
Copy link
Member

WG21-P3136R1 Retiring Niebloids

No feature-test macro is mentioned.

This was unconditionally implemented by #4098. We just need to list this paper in the C++20 section of <yvals_core.h>.
@StephanTLavavej StephanTLavavej added cxx26 C++26 feature ranges C++20/23 ranges labels Nov 25, 2024
@github-project-automation github-project-automation bot moved this to Unimplemented in STL C++26 Features Nov 25, 2024
@StephanTLavavej StephanTLavavej moved this from Unimplemented to Available in STL C++26 Features Nov 25, 2024
@frederick-vs-ja
Copy link
Contributor

Looks like that the only thing left to do is adding one comment line (saying // P3136R1 Retiring Niebloids) after this one.

STL/stl/inc/yvals_core.h

Lines 316 to 317 in 5e0ddad

// P2997R1 Removing The Common Reference Requirement From The Indirectly Invocable Concepts

Presumably this should be "good first issue".

@CaseyCarter CaseyCarter added the good first issue Good for newcomers label Nov 30, 2024
@alexprabhat99 alexprabhat99 mentioned this issue Dec 16, 2024
Merged
@github-project-automation github-project-automation bot moved this from Available to Done in STL C++26 Features Dec 18, 2024
@CaseyCarter CaseyCarter added the fixed Something works now, yay! label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cxx26 C++26 feature fixed Something works now, yay! good first issue Good for newcomers ranges C++20/23 ranges
Projects
STL C++26 Features
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update C++20 section of <yvals_core.h> for WG21-P3136R1 Retiring Niebloids alexprabhat99/STL
3 participants
@CaseyCarter @StephanTLavavej @frederick-vs-ja