Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unskip sized deallocation tests with clang #4710

Closed
h-vetinari opened this issue Jun 4, 2024 · 3 comments · Fixed by #5247
Closed

Unskip sized deallocation tests with clang #4710

h-vetinari opened this issue Jun 4, 2024 · 3 comments · Fixed by #5247
Labels
fixed Something works now, yay! test Related to test code

Comments

@h-vetinari
Copy link

I saw the following

# *** CLANG ISSUES, NOT YET ANALYZED ***
# Clang doesn't enable sized deallocation by default. Should we add -fsized-deallocation or do something else?
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array_fsizeddeallocation.pass.cpp:2 SKIPPED
std/language.support/support.dynamic/new.delete/new.delete.array/sized_delete_array14.pass.cpp:2 SKIPPED
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete_fsizeddeallocation.pass.cpp:2 SKIPPED
std/language.support/support.dynamic/new.delete/new.delete.single/sized_delete14.pass.cpp:2 SKIPPED

This must have narrowly missed the update in #4702, because clang now finally supports (since llvm/llvm-project@130e93c) sized allocation by default, see also here.

@frederick-vs-ja
Copy link
Contributor

I'd like to add -fsized-deallocation at this moment and say TRANSITION, Clang 19, LLVM-90373.

@StephanTLavavej StephanTLavavej added the test Related to test code label Jun 12, 2024
@StephanTLavavej
Copy link
Member

FYI, my PR #4713 updates LLVM sufficiently to pick up that commit.

@frederick-vs-ja
Copy link
Contributor

This will be resolved by recent toolset update #5247.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fixed Something works now, yay! test Related to test code
Projects
None yet
3 participants