Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calls to vector algorithms need qualification to avoid ADL #4043

Closed
AlexGuteniev opened this issue Sep 21, 2023 · 1 comment · Fixed by #4256
Closed

Calls to vector algorithms need qualification to avoid ADL #4043

AlexGuteniev opened this issue Sep 21, 2023 · 1 comment · Fixed by #4256
Labels
bug Something isn't working fixed Something works now, yay!

Comments

@AlexGuteniev
Copy link
Contributor

AlexGuteniev commented Sep 21, 2023 •
edited by CaseyCarter
Loading

Per https://github.com/microsoft/STL/pull/3928/files#r1287824862, we need to qualify calls to the __ugly vector algorithms to avoid unintentional ADL e.g. when passing pointers-to-pointers-to-program-defined-types.
@CaseyCarter CaseyCarter changed the title Some vector algorithms are not ADL aware Calls to vector algorithms need qualification to avoid ADL Sep 21, 2023
@CaseyCarter CaseyCarter added the bug Something isn't working label Sep 21, 2023
@frederick-vs-ja
Copy link
Contributor

I think I'm doing this in #4004.

@frederick-vs-ja frederick-vs-ja mentioned this issue Nov 24, 2023
Merged
@frederick-vs-ja frederick-vs-ja mentioned this issue Dec 11, 2023
Merged
@StephanTLavavej StephanTLavavej added the fixed Something works now, yay! label Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working fixed Something works now, yay!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ADL-proof implementation of [alg.modifying.operations] frederick-vs-ja/STL
4 participants
@CaseyCarter @AlexGuteniev @StephanTLavavej @frederick-vs-ja